bugLibCVS Perl Implementation - Bugs: bug #14188, Cleaning up paths in...

 
 

bug #14188: Cleaning up paths in RepositoryFileOrDirectory

Submitter:  Alexander Taler <dissent>
Submitted:  Wed 17 Aug 2005 04:42:30 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Release:  None Fixed Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 17 Aug 2005 04:42:30 PM UTC, original submission:  

In the constructor of RepositoryFileOrDirectory,
File::Spec is used to clean up the supplied path.
 But this doesn't do quite enough.  Most
importantly I want to make sure it points into the
repository, by looking for "../".

Perhaps "foo/../bar" could be changed to "bar",
but how is this handled with symlinks?



------- Additional comments from Alexander Taler Thu Jun 26 12:58:38 -0700 2003 -------

The routine get_directory_of totally screws up if there is a .. in the
path.  This is a good reason to fix it.



------- Additional comments from Alexander Taler Sun May 16 10:04:28 -0700 2004 -------

Also, the question is if absolute paths should be treated
as relative the repository root.  This would be useful for
programs (like lcvs-logsummary) which can accept absolute
paths to indicate files relative the repository root, and
relative paths to indicate files relative to the cwd.

For the moment I'm just going to strip off the leading /
before submitting the filename.

Alexander Taler <dissent>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-cf05.
Corresponding source code