bugrdiff-backup - Bugs: bug #16852, Rdiff-backup crash on case...

 
 

bug #16852: Rdiff-backup crash on case sensitivity test

Submitter:  None
Submitted:  Thu 15 Jun 2006 08:56:47 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 19 May 2007 06:56:06 PM UTC, comment #4: 

Indeed, stale data turned out to be the case.

User can fix with:

$ echo 0 > /proc/fs/cifs/LookupCacheEnabled

This fix was presented in bug 19802. Credit to Jonathan Hankins.

Andrew Ferguson <owsla>
Group administrator
Mon 13 Nov 2006 09:08:33 PM UTC, comment #3: 

Now that I have a Savannah account, I want to mention that I posted comment #2.

Andrew Ferguson <owsla>
Group administrator
Mon 13 Nov 2006 03:59:12 AM UTC, comment #2: 

I think what's happening here is that the .lstat() calls in fs_abilities.py:242 (within .setdata() and directly in the function) are being fed stale data by Samba. Perhaps, Samba's information about the file 'A' isn't immediately updated after the file 'a' is changed.

One could write this of as a Samba bug (and an unsupported configuration for rdiff-backup), but an appropriate use of fsync_local() calls could fix this situation.


Anonymous
Sat 16 Sep 2006 07:30:33 PM UTC, comment #1: 

See http://bugs.debian.org/386983 for some more comments.

Elmar Hoffmann <elho>
Thu 15 Jun 2006 08:56:47 PM UTC, original submission:  

Rdiff-backup 1.1.5 crashes when I try to create the first backup of any folder to a partition mounted over Samba on a Linux machine. The target partition on the Windows XP box is of type NTFS and normal reading/writting to the folder works fine. The target is mounted as: localip/Backup on /mnt/backup type cifs (rw,mand)

I hope the problematic assert is this one (if not, then the summary I wrote is wrong, but the bug is still there):
---
lower_a = subdir.append("a") <2071>
if lower_a.lstat(): <2071>
lower_a.delete() <2071>
upper_a.setdata() <2071>
assert not upper_a.lstat() <2071>
self.case_sensitive = 0 <2071>
---

And I get this if I try to backup a folder called xx to yy on  this partition:
---
$ rdiff-backup -v9 -b xx yy
Thu Jun 15 22:37:44 2006  Making directory yy
Thu Jun 15 22:37:44 2006  Making directory yy/rdiff-backup-data
Thu Jun 15 22:37:44 2006  Unable to import module xattr.
Extended attributes not supported on filesystem at xx
Thu Jun 15 22:37:44 2006  Unable to import module posix1e from pylibacl package.
ACLs not supported on filesystem at xx
Thu Jun 15 22:37:44 2006  -----------------------------------------------------------------
Detected abilities for source (read only) file system:
  Access control lists                         Off
  Extended attributes                          Off
  Case sensitivity                             Off
  Mac OS X style resource forks                Off
  Mac OS X Finder information                  Off
-----------------------------------------------------------------
Thu Jun 15 22:37:44 2006  Making directory yy/rdiff-backup-data/rdiff-backup.tmp.0
Thu Jun 15 22:37:44 2006  Touching yy/rdiff-backup-data/rdiff-backup.tmp.0/5-_ a.
Thu Jun 15 22:37:44 2006  Deleting yy/rdiff-backup-data/rdiff-backup.tmp.0/5-_ a.
Thu Jun 15 22:37:44 2006  Touching yy/rdiff-backup-data/rdiff-backup.tmp.0/:\ ᄉ
Thu Jun 15 22:37:44 2006  Touching yy/rdiff-backup-data/rdiff-backup.tmp.0/A
Thu Jun 15 22:37:44 2006  Deleting yy/rdiff-backup-data/rdiff-backup.tmp.0/a
Thu Jun 15 22:37:44 2006  Exception '' raised of class 'exceptions.AssertionError':
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 295, in error_check_Main
    try: Main(arglist)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 315, in Main
    take_action(rps)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 271, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 325, in Backup
    rpout.conn.fs_abilities.backup_set_globals(rpin)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 602, in backup_set_globals
    dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 138, in init_readwrite
    self.set_case_sensitive_readwrite(subdir)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 242, in set_case_sensitive_readwrite
    assert not upper_a.lstat()

Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 23, in ?
    rdiff_backup.Main.error_check_Main(sys.argv[1:])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 295, in error_check_Main
    try: Main(arglist)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 315, in Main
    take_action(rps)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 271, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/lib/python2.3/site-packages/rdiff_backup/Main.py", line 325, in Backup
    rpout.conn.fs_abilities.backup_set_globals(rpin)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 602, in backup_set_globals
    dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 138, in init_readwrite
    self.set_case_sensitive_readwrite(subdir)
  File "/usr/lib/python2.3/site-packages/rdiff_backup/fs_abilities.py", line 242, in set_case_sensitive_readwrite
    assert not upper_a.lstat()
AssertionError
---

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by owsla (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-18 owsla Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code