bugConcurrent Versions System - Bugs: bug #17083, CVSROOT of...

 
 

bug #17083: CVSROOT of :gserver:user@host:/path ignores "user" part...

Submitted by:  Marc W. Mengel <mengel>
Submitted on:  Tue 11 Jul 2006 06:20:43 PM UTC  
Votes:  90  
 
Category:  Bug Fix (patch attached) Severity:  1 - Wish
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Mark D. Baushke <mdb>
Open/Closed:  Closed Release: 
Fixed Release:  None Fixed Feature Release:  1.12.14

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 13 Jun 2007 06:21:30 AM UTC, comment #4: 

I have applied the patch to support the :gserver:luser@host:/path
method using a new GSSAPI-U authentication request between the
client and the server.

Mark D. Baushke <mdb>
Project AdministratorIn charge of this item.
Tue 05 Jun 2007 07:21:46 PM UTC, comment #3: 

Mark,

Thanks for looking into this!

The patches you linked below work for me, both for :gserver:user@host:/path and :gserver:host:/path in both releases (except that the FEATURE branch gives an error on checkout:
cvs [checkout aborted]: No signature for `erupd/Makefile'.
but I believe that is unrelated to this patch, as I get the same failure with :ext: as with :gserver:).

Operations (status, update, commit) on a checked-out copy work with the FEATURE branch.

Marc W. Mengel <mengel>
Sat 26 May 2007 07:39:56 AM UTC, comment #2: 

I do not have any easy way to verify that the patches to
CVS 1.11.x (currently STABLE is at 1.11.22.1 if you checkout
the latest branch from the respoitory) and CVS 1.12.x
(currently FEATURE is at 1.12.13.1 if you checkout the
latest main trunk from the repository).

[Please note that your patch as written would fail on a
pure K&R C compiler due to the use of a prototype in the
gserver_authenticate_connection function definition.]

I have attached a patch for each of these branches:

cvs -z3 -d:pserver:anonymous@cvs.savannah.nongnu.org:/sources/cvs co ccvs

cvs -z3 -d:pserver:anonymous@cvs.savannah.nongnu.org:/sources/cvs co -rcvs1-11-x-branch ccvs

If you could validate that these patches work properly for
both :gserver:host:/path and :gserver:user@host:/path then
I will commit these changes to the FEATURE branch first and
if there are no complaints, I will ask my fellow developers
to vote on apply the patch to the STABLE branch.

(file #12862, file #12863)

Mark D. Baushke <mdb>
Project AdministratorIn charge of this item.
Wed 02 May 2007 04:27:25 PM UTC, comment #1: 

Is there any chance this patch will ever get looked at and maybe included in a release?

Marc W. Mengel <mengel>
Tue 11 Jul 2006 06:20:43 PM UTC, original submission:  

When using cvs with a CVSROOT of :gserver:user@host:/path, the gss-api code ignores the "user" part.   It should check, and log in as, the mentioned user, as rsh, ssh, etc. do.

To reproduce:

  • build cvs with gssapi/kerberos support
  • setup a pserver access on a server with kerberos
  • put your principal in another user's (i.e. "cvsuser")

  .k5login file

  • try to checkout, etc. with CVSROOT of :gserver:cvsuser@host:/path
  • note that it connects as you, not cvsuser
Marc W. Mengel <mengel>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #12862:  cvs-1.12.13.1-gssapi.patch added by mdb (4KiB - text/x-patch - Updated patch for cvs 1.12.13.1 and cvs 1.11.22.1 (FEATURE and STABLE branches))
file #12863:  cvs-1.11.22.1-gssapi.patch added by mdb (4KiB - text/x-patch - Updated patch for cvs 1.12.13.1 and cvs 1.11.22.1 (FEATURE and STABLE branches))
file #10335:  gssapi-patch added by mengel (5KiB - application/octet-stream - Patch to fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mdb (Updated the item)
  • -email is unavailable- added by mengel (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 90 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-13 mdb StatusNone => Fixed
    2007-06-13 mdb Open/ClosedOpen => Closed
        Fixed Feature ReleaseNone => 1.12.14
    2007-05-26 mdb Attached File- => Added cvs-1.12.13.1-gssapi.patch, #12862
        Attached File- => Added cvs-1.11.22.1-gssapi.patch, #12863
        Severity3 - Normal => 1 - Wish
        Assigned toNone => mdb
    2006-08-08 mengel Carbon-Copy- => Added mengel
    2006-07-11 mengel Attached File- => Added gssapi-patch, #10335

    Back to the top


    Powered by Savane 3.5