bugAVR C Runtime Library - Bugs: bug #18964, USART definitions *wrong* in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #18964: USART definitions *wrong* in iocanxx.h

Submitter:  None
Submitted:  Mon 05 Feb 2007 05:33:28 PM UTC
   
 
Category:  Header Severity:  3 - Normal
Priority:  7 - High Item Group:  libc code
Status:  Fixed Assigned to:  joerg_wunsch
Percent Complete:  0% Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  None
Fixed Release:  None

Tue 23 Oct 2007 12:28:38 PM UTC, comment #3: 

While the SIG_xxx names are deprecated, it seems counterintuitive
that the SIG_UART* names were there but the SIG_USART* names
weren't, so I applied the patch.

Joerg Wunsch <joerg_wunsch>
Group administrator
Fri 30 Mar 2007 05:18:26 PM UTC, comment #2: 

From the avr-libc user manual:

"Starting with avr-libc version 1.4.0, a second style of interrupt vector names has been added, where a short phrase for the vector description is followed by _vect. The short phrase matches the vector name as described in the datasheet of the respective device (and in Atmel's XML files), with spaces replaced by an underscore and other non-alphanumeric characters dropped. Using the suffix _vect is intented to improve portability to other C compilers available for the AVR that use a similar naming convention.

The historical naming style might become deprecated in a future release, so it is not recommended for new projects."

Note the last sentence. The iocanxx.h has the correct naming with the "USART*" prefix. The vector names that start with "SIG*" should not be used anymore.

Eric Weddington <arcanum>
Group administrator
Sun 25 Mar 2007 03:11:37 AM UTC, comment #1: 

Attached patch fixes this.

 -Colin

(file #12282)

Colin O Flynn <c_oflynn>
Mon 05 Feb 2007 05:33:28 PM UTC, original submission:  

Hello

the iocanxx.h lacks some vector definitions.
I saw it because the Aversive lib uses the presence of the USART vectors to detect if it is an UART or USART.

iocanxx.h :
/* USART0, Rx Complete */
#define USART0_RX_vect _VECTOR(21)
#define SIG_UART0_RECV _VECTOR(21)

iom128.h :
/* USART0, Rx Complete */
#define USART0_RX_vect _VECTOR(18)
#define SIG_USART0_RECV _VECTOR(18)
#define SIG_UART0_RECV _VECTOR(18)

it cis in my opinion logical to add the usart defined vectors.

Tschüss

christoph

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12282:  bug18964.diff added by c_oflynn (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by c_oflynn (Updated the item)
  • -email is unavailable- added by arcanum (Updated the item)
  •  

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-23 joerg_wunsch StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2007-05-06 arcanum Priority9 - Immediate 7 - High
        StatusInvalid Need Info
    2007-03-30 arcanum Assigned toarcanum joerg_wunsch
        Open/ClosedClosed Open
    2007-03-30 arcanum StatusNone Invalid
        Assigned toNone arcanum
        Open/ClosedOpen Closed
    2007-03-25 c_oflynn Attached File- Added bug18964.diff, #12282
    2007-03-25 arcanum Priority5 - Normal 9 - Immediate

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code