bugmldonkey, a multi-networks file-sharing client - Bugs: bug #19387, Reassigned to another tracker...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #19387: Reassigned to another tracker [was: HTML: Keep totals line when sorting statistics tables]

Submitter:  orbit <orbit>
Submitted:  Fri 23 Mar 2007 01:28:17 AM UTC
   
 
Category:  HTTP interface Severity:  2 - Minor
Item Group:  Program malfunction Status:  Ready For Test
Assigned to:  None Open/Closed:  Closed
Release:  None Release: 
Operating System:  None Binaries Origin:  None
CPU type:  None

Jump to the original submission

Mon 02 Apr 2007 06:52:11 PM UTC, comment #7: 

THIS ITEM WAS REASSIGNED TO PATCH #5844.

Please, do not post any new comments to this item.


spiralvoice <spiralvoice>
Group administrator
Mon 02 Apr 2007 05:51:47 PM UTC, comment #6: 


>> I just noticed that in the country stats there a entries without any total seen peer but some upload.
> can't confirm your observations here, all 'costats' entries are at least seen one time


perhaps it's network bound, i use ed2k, ov, kad and bt
uptime with country code stats: 21d, total seen: 140000

orbit <orbit>
Mon 02 Apr 2007 05:41:03 PM UTC, comment #5: 

updated patch -> small html fixes from "countries" output

quote from "orbit" ->
  I just noticed that in the country stats there a entries without any total seen peer but some upload. <-

can't confirm your observations here, all 'costats' entries are at least seen one time

(file #12379)

Schlumpf <schlumpf_>
Group Member
Mon 02 Apr 2007 02:33:10 PM UTC, comment #4: 

just from the look, it should work.
didn't thought of such a solution
good work Schlumpf

I just noticed that in the country stats there a entries without any total seen peer but some upload.

orbit <orbit>
Mon 02 Apr 2007 01:09:42 PM UTC, comment #3: 

please try out the attached patch, it also fix an little bug from costats that not all flags appear.

Please report for all Browsers if the patch works

(file #12378)

Schlumpf <schlumpf_>
Group Member
Wed 28 Mar 2007 12:00:36 PM UTC, comment #2: 

I found a german example for sorting a table with head and foot
http://professionelle-websites.de/k08tabsjs.htm

I don't know what "this" in "_tabSort(this,0)" is?
When we replace "this" with a "row id", "html_mods_table_header" in printf2 must be modified.



(file #12321)

orbit <orbit>
Wed 28 Mar 2007 12:30:29 AM UTC, comment #1: 

Attached submit.htm, which is a sample of how the costats
table could look like. It still throws some errors on
validator.w3.org but much less than before;-)

Why is the sorting gone now?
Clicking on table rows does nothing now.

I am not a HTML expert;-)

I guess this happenes due to this patch in printf2.ml
as sorting is disabled now in all tables...


 let html_mods_table_header buf n c l =
     (* Name Class List *)
-    Printf.bprintf buf "\\<div class=\\\"%s\\\"\\>\\<table id=\\\"%s\\\" name=\\\"%s\\\" class=\\\"%s\\\" cellspacing=0 cellpadding=0\\>"
+    Printf.bprintf buf "\\<div class=\\\"%s\\\"\\>\\<table id=\\\"%s\\\" name=\\\"%s\\\" class=\\\"%s\\\" cellspacing=0 cellpadding=0\\>\\<thead\\>"
     c n n c;
     if List.length l > 0 then begin
         Printf.bprintf buf "\\<tr\\>";
@@ -313,7 +307,8 @@
          w x y z;
         ) l;
         Printf.bprintf buf "\\</tr\\>"
-      end
+      end;
+    Printf.bprintf buf "\\</thead\\>\n"


(file #12313)

spiralvoice <spiralvoice>
Group administrator
Fri 23 Mar 2007 01:28:17 AM UTC, original submission:  

THIS ITEM WAS REASSIGNED TO PATCH #5844.

at the moment when you sort the statistics the Total row is equal treated to the clients. So when you sort e.g. by brand it looks like this:

aMule
eMule
ePlus
Total
trusted mld

we could prevent this if we use <tfoot> </tfoot>for Totals
(note: it important to use this order thead -> tfoot -> tbody, this could be difficult)

I look in the code and unfortunately I can't do this with my current skills. Perhaps someone with more experience with the web interface code can do this.

PS: if this doesn't work. It is also possible to use more than one tbody perhaps we could sort only the first one?

w3.org
selfHTML

orbit <orbit>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by schlumpf_ (Updated the item)
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by orbit (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-02 spiralvoice Reassign Itemmldonkey, a multi-networks file-sharing client, bug #19387 mldonkey, a multi-networks file-sharing client, patch #5844
    2007-04-02 spiralvoice SummaryHTML don't sort Totals in statistic tables HTML: Keep totals line when sorting statistics tables
    2007-04-02 spiralvoice Attached File#12313 Removed
    2007-04-02 spiralvoice Attached File#12321 Removed
    2007-04-02 schlumpf_ Attached File#12378 Removed
    2007-04-02 schlumpf_ Attached File- Added html_no_sort_totals2.patch, #12379
    2007-04-02 schlumpf_ StatusIn Progress Ready For Test
        SummaryHTML don't sort Totals in stat tables HTML don't sort Totals in statistic tables
    2007-04-02 schlumpf_ Attached File- Added html_no_sort_totals.patch, #12378
    2007-03-28 orbit Attached File- Added submit.htm, #12321
    2007-03-28 spiralvoice Severity3 - Normal 2 - Minor
        Item GroupFeature request Program malfunction
        StatusNone In Progress
    2007-03-28 spiralvoice Attached File- Added submit.htm, #12313

    Back to the top

    Powered by Savane 3.12