bugrdiff-backup - Bugs: bug #19612, error when using --no-compression:...

 
 

bug #19612: error when using --no-compression: no _log_inc_rp in class ErrorLog

Submitted by:  None
Submitted on:  Tue 17 Apr 2007 03:08:53 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 May 2007 10:40:37 PM UTC, comment #1: 

Thanks for the fix. This has been applied in CVS towards version 1.1.11.

Andrew Ferguson <owsla>
Project Administrator
Tue 17 Apr 2007 03:08:53 AM UTC, original submission:  

When using rdiff-backup with the --no-compression option, an error message complains that there is no _log_inc_rp in the class ErrorLog (line 216 of log.py)

I checked the source and, indeed, there is no member _log_inc_rp in that class. It seems to me that the code probably was changed but that line was forgotten in place. In any case, replacing line 216 with the one below seemed to do the job:

else: cls._log_fileobj = base_rp.open("wb", compress = 0)

Since I didn't take more than 10 minutes in solving this (and had never looked at this source before), I'm not entirely sure that this is the correct line. Does anyone know?

- Thiago

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by owsla (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-05-19 owsla Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5