lwIP - A Lightweight TCP/IP stack - Bugs: bug #20779, Keep-Alive and SYNs
You are not allowed to post comments on this tracker with your current authentication level.
bug #20779: Keep-Alive and SYNs
Submitter: | Oleg Tyshev <olegreen> | ||
Submitted: | Tue 14 Aug 2007 09:43:55 AM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | kieranm |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.3.0 |
Jump to the original submission
Tue 31 Mar 2009 10:56:14 AM UTC, comment #17: |
Kieran Mansley <kieranm> |
Thu 26 Mar 2009 04:01:35 PM UTC, comment #16: It looks good now.
|
Oleg Tyshev <olegreen> |
Thu 26 Mar 2009 02:15:56 PM UTC, comment #15: OK, how about this?
|
Kieran Mansley <kieranm> |
Wed 25 Mar 2009 05:21:47 PM UTC, comment #14: That's OK.
|
Oleg Tyshev <olegreen> |
Wed 25 Mar 2009 02:03:50 PM UTC, comment #13: How's this for a patch to solve this problem:
|
Kieran Mansley <kieranm> |
Fri 09 Nov 2007 01:04:02 PM UTC, comment #12: Sounds reasonable. However, I'm going to drop this from gating 1.3.0 unless anyone can provide a complete patch. |
Kieran Mansley <kieranm> |
Mon 10 Sep 2007 01:29:51 PM UTC, comment #11: Of couкse, I mean only synchronized states where we don't await SYN. |
Oleg Tyshev <olegreen> |
Mon 10 Sep 2007 01:24:19 PM UTC, comment #10: I think, that in tcp_process() should be added SYN check for any state.
|
Oleg Tyshev <olegreen> |
Wed 29 Aug 2007 09:33:01 AM UTC, comment #9: Sorry, since I'm not TCP expert, I can't propose better than my comment #6 solution (for the moment ;) ) |
Frédéric Bernon <fbernon> |
Tue 14 Aug 2007 02:09:06 PM UTC, comment #8: Stats is OK.
|
Oleg Tyshev <olegreen> |
Tue 14 Aug 2007 01:31:13 PM UTC, comment #7: Re comment #3: a new SYN should not kill an existing connection surely! As per the bit of RFC793 that Oleg quoted, it should only be killed by a RST.
|
Jonathan Larmour <jifl> |
Tue 14 Aug 2007 12:28:27 PM UTC, comment #6: No objects to add these errors stats? (and yes, I know, it's not directly a patch for this bug report, sorry)
|
Frédéric Bernon <fbernon> |
Tue 14 Aug 2007 12:17:39 PM UTC, comment #5: if ((flags & TCP_SYN) && (pcb->state != LISTEN) && (pcb->state != SYN_SENT)) {
|
Frédéric Bernon <fbernon> |
Tue 14 Aug 2007 12:13:15 PM UTC, comment #4: if ((flags & TCP_SYN) && (pcb->state != LISTEN) && (pcb->state != SYN_RCVD) && (pcb->state != SYN_SENT)) {
|
Frédéric Bernon <fbernon> |
Tue 14 Aug 2007 12:06:22 PM UTC, comment #3: If the problem is due to tcp_process's lines you give, I think the the filter should be done in tcp_input to avoid to "tcp_process" the old pcb. Perhaps do something like:
|
Frédéric Bernon <fbernon> |
Tue 14 Aug 2007 11:55:36 AM UTC, comment #2: This case is described in RFC 793:
|
Oleg Tyshev <olegreen> |
Tue 14 Aug 2007 09:49:30 AM UTC, comment #1: May be I too narrow described the problem.
|
Oleg Tyshev <olegreen> |
Tue 14 Aug 2007 09:43:55 AM UTC, original submission:
Hello All,
|
Oleg Tyshev <olegreen> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-03-31 | kieranm | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2008-03-25 | kieranm | Assigned to | None | kieranm | |
2008-03-04 | kieranm | Planned Release | 1.3.1 | ||
2007-11-09 | kieranm | Severity | 4 - Important | 3 - Normal | |
Planned Release | 1.3.0 | ||||
2007-08-29 | kieranm | Severity | 3 - Normal | 4 - Important | |
Planned Release | 1.3.0 |
Powered by Savane 3.13-d3ae.
Corresponding source code
OK, fix checked in. Hopefully this will get some testing now. Resolving as fixed.