bugSamizdat - Bugs: bug #21286, usability BUG: takeover user text...

 
 

bug #21286: usability BUG: takeover user text string inconsistent with behaviour

Submitter:  Boud Roukema <boud>
Submitted:  Sun 07 Oct 2007 05:30:27 PM UTC
   
 
Category:  None Severity:  3 - Normal
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 21 Feb 2008 05:44:47 PM UTC, comment #1: 

Fixed in CVS since 2007-11-04.

The change to not to change message attribution on moderation was intentional, the change of attribution was necessary for transparency and is now superceded by per-message "moderation log" link which provides enough transparency without confusing users about who the real author of the message is.

Dmitry Borodaenko <angdraug>
Group administrator
Sun 07 Oct 2007 05:30:27 PM UTC, original submission:  

PROBLEM: In 070818-1 (probably since the earlier refactoring),
the information given to the moderator when using the TAKE OVER
function says that the message will be attributed to that user
afterwards, but this is not true, since set_creator is not
used.  For the REPLACE function, no such info is given to the
moderator, but transparency e.g. in the message info and in
the history would suggest that the message should be attributed
to that moderator after the intervention.  Otherwise, the
intervention is only obvious in e.g. when using the /moderation
function.


SOLUTION:
Either the message about attribution should be changed, or
attribution should be implemented. My suggestion is to keep
the older behaviour (AFAIR) in which attribution is made,
and also do this for REPLACE.  If some people really don't want
this, then the question is whether they should have to edit
the ruby code or we should add this as a configurable parameter.

Any thoughts?

Anyway, here's the patch.

cheers
boud



--- /usr/lib/ruby/1.8/samizdat/controllers/message_controller.rb~       2007-10-07 19:14:49.479497088
+0200
+++ /usr/lib/ruby/1.8/samizdat/controllers/message_controller.rb        2007-10-07 19:19:35.010089840
+0200
@@ -336,6 +336,7 @@
     @message = Message.cached(@id)
     @message.assert_current_version

+    set_creator  # consistency with 'The message will be attributed to you after takeover'
     set_content
     set_lang(@message.lang)
     set_desc
@@ -372,6 +372,7 @@
     assert_moderate

     @message = Message.cached(@id)
+    set_creator  # otherwise intervention is insufficiently transparent
     set_content
     set_lang(@message.lang)
     set_desc




Boud Roukema <boud>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by angdraug (Posted a comment)
  • -email is unavailable- added by boud (Submitted the item)
  •  

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-02-21 angdraug StatusWorks For Me Fixed
        Open/ClosedOpen Closed
    2007-10-07 boud Attached File- Added takeover_transparency-0.1.patch, #14111

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code