bugJailkit - Bugs: bug #21555, Makefile changes results in deb...

 
 

bug #21555: Makefile changes results in deb package build filing - diff to debian/rules to fix problem is attached

Submitter:  None
Submitted:  Sun 11 Nov 2007 02:02:53 AM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 14 Nov 2007 09:08:31 PM UTC, comment #5: 

fixed in cvs

Olivier Sessink <oli4>
Project Administrator
Sun 11 Nov 2007 07:49:24 PM UTC, comment #4: 

Well, I do not really think, that we will use BSD make to create the Debian package ;) I was referring to debian/rules only, not to your Makefiles.

Daniel Leidert <dleidert>
Sun 11 Nov 2007 07:35:44 PM UTC, comment #3: 

I vaguely recall that make -C doesn't work on openbsd, and that cd src && make is the more portable way. But I'm not sure about it...

Olivier Sessink <oli4>
Project Administrator
Sun 11 Nov 2007 03:01:33 PM UTC, comment #2: 

Further instead of:

cd src && $(MAKE) install prefix=$(CURDIR)/debian/jailkit/usr

you should do:

$(MAKE) -C src/ install DESTDIR=$(CURDIR)/debian/$(PACKAGE)

(PACKAGE must be defined in this case of course) in debian/rules.

Daniel Leidert <dleidert>
Sun 11 Nov 2007 02:58:22 PM UTC, comment #1: 

I see. The attached simple patch will fix this. This is a regression from using ${bindir} instead of ${prefix}/bin, because bindir is set to ${exec_prefix}/bin. So exec_prefix must be defined in the related Makefiles too. So the patch simply adds:

exec_prefix = @exec_prefix@

to these Makefile.in files.

(file #14357)

Daniel Leidert <dleidert>
Sun 11 Nov 2007 02:02:53 AM UTC, original submission:  

One of the changes to the Makefiles in the jailkit/py directory is to use 'exec_prefix' instead of 'prefix' when installing the py sbin binaries.

This causes 'dpkg-buildfile -rfakeroot -b' to fail because exec_prefix is not being set, resulting in the package trying to install directly to /sbin rather than to $(sourcedir)/debian/jailkit/sbin.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #14357:  jailkit_exec_prefix.diff added by dleidert (902B - text/x-patch - Simple patch to fix the regression.)
file #14356:  diff.log added by None (765B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by oli4 (Posted a comment)
  • -email is unavailable- added by dleidert (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-11-14 oli4 StatusNone Fixed
        Open/ClosedOpen Closed
    2007-11-11 dleidert Attached File- Added jailkit_exec_prefix.diff, #14357
    2007-11-11 None Attached File- Added diff.log, #14356

    Back to the top


    Powered by Savane 3.9