lwIP - A Lightweight TCP/IP stack - Bugs: bug #21664, PPP code is broken
You are not allowed to post comments on this tracker with your current authentication level.
bug #21664: PPP code is broken
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Wed 28 Nov 2007 07:23:23 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | Other |
Jump to the original submission
Sat 02 May 2009 04:58:27 PM UTC, comment #19: |
Frédéric Bernon <fbernon> |
Sat 02 May 2009 04:14:17 PM UTC, comment #18: Frédéric, this is mainly to you: I think we can close this bug - for me, PPP at least compiles (unfortunately I cannot test it).
|
Simon Goldschmidt <goldsimon> |
Sat 02 May 2009 04:12:06 PM UTC, comment #17: May be a little late, but just my 2cents on comment #14 and the attached files:
|
Simon Goldschmidt <goldsimon> |
Wed 27 Feb 2008 03:25:26 PM UTC, comment #16: I made a mistake on the ppp.c changes. I don't know what I was thinking in that there was sys_thread_remove() for lwIP along with sys_thread_new(). I am sorry about wasting your time with that. As a side note for anyone using the PPP client, if you end a PPP session, the PPP thread must be removed. |
Dustin Stahlback <dstahlback> |
Tue 26 Feb 2008 09:30:56 PM UTC, comment #15: For ppp.c changes, I see you call sys_arch_thread_remove and sys_arch_thread_current, but these functions are not defined for lwIP. So, your patch can't be integrate like this...
|
Frédéric Bernon <fbernon> |
Tue 26 Feb 2008 08:44:16 PM UTC, comment #14: I have an interest in a proper working serial PPP client. I have made changes to a couple of the PPP files to allow the client to work for me. I would like to submit the changes for review. Could you tell me how you would like patches submitted? I have attached the three files modified from the current working CVS as of 02/26/2008.
|
Dustin Stahlback <dstahlback> |
Wed 19 Dec 2007 08:48:40 PM UTC, comment #13: Some changes for coding style. |
Frédéric Bernon <fbernon> |
Sun 02 Dec 2007 08:30:44 PM UTC, comment #12:
|
Simon Goldschmidt <goldsimon> |
Sun 02 Dec 2007 06:52:10 PM UTC, comment #11:
|
Frédéric Bernon <fbernon> |
Sun 02 Dec 2007 06:21:18 PM UTC, comment #10: I agree to almost all points. But the queue.h file is only needed in the relatively new file ppp_oe.c, so it doesn't really seem necessary to test ppp only... Maybe we can ask Marc Boucher (he implemented the ppp_oe file) to remove the need for queue.h? |
Simon Goldschmidt <goldsimon> |
Sun 02 Dec 2007 05:22:26 PM UTC, comment #9: In a first step, I want to fix major build problems before really do more code changes. Adding this file is a temporary solution to let user use it.
|
Frédéric Bernon <fbernon> |
Sat 01 Dec 2007 01:13:29 PM UTC, comment #8: Do we really need that? Other lists are made up of a simple 'next' pointer, too. I currently don't know what the queue is used for, but if a next pointer is enough, I think we should use that instead of adding an extra queue.h file... |
Simon Goldschmidt <goldsimon> |
Fri 30 Nov 2007 07:00:17 PM UTC, comment #7: I would like to add this file (modified from FreeBSD). I'm not a license expert, but I think there is not real problems to use it. Of course, it's a temporary workaround until we provide our own list. |
Frédéric Bernon <fbernon> |
Fri 30 Nov 2007 05:38:48 PM UTC, comment #6:
|
Frédéric Bernon <fbernon> |
Fri 30 Nov 2007 05:35:00 PM UTC, comment #5: About comment #3, the problem is always the CVS history. There is lot of files to move, so, it's more a separate issue.
|
Frédéric Bernon <fbernon> |
Fri 30 Nov 2007 11:59:55 AM UTC, comment #4: embed9527 wrote on lwip-users:
|
Simon Goldschmidt <goldsimon> |
Fri 30 Nov 2007 11:55:57 AM UTC, comment #3: Should we move the ppp headers from src/netif/ppp/ to src/include/netif/ppp/ (create ppp include directory)?
|
Simon Goldschmidt <goldsimon> |
Fri 30 Nov 2007 07:42:50 AM UTC, comment #2: on lwip-users, embed9527 wrote:
|
Simon Goldschmidt <goldsimon> |
Thu 29 Nov 2007 01:45:42 AM UTC, comment #1: I ever used RASPPPoE to make windows work as a PPPoE server
|
Bockham Zhao <bockham> |
Wed 28 Nov 2007 07:23:23 PM UTC, original submission:
This is not a news, but PPP code is actually broken. I have start to do some fix to be able to build it, and to test it.
|
Frédéric Bernon <fbernon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-05-02 | fbernon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2008-02-26 | dstahlback | Attached File | - | Added ppp.h, #15118 | |
Attached File | - | Added ppp.c, #15119 | |||
Attached File | - | Added sio.h, #15120 | |||
2007-11-30 | fbernon | Attached File | - | Added queue.h, #14518 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Agree with you