lwIP - A Lightweight TCP/IP stack - Bugs: bug #24212, Deadlocked tcp_retransmit due to...
You are not allowed to post comments on this tracker with your current authentication level.
bug #24212: Deadlocked tcp_retransmit due to exceeded pcb->cwnd
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Sat 06 Sep 2008 08:44:51 AM UTC | ||
Votes: | 20 | ||
Category: | TCP | Severity: | 4 - Important |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.3.0 |
Jump to the original submission
Sun 26 Apr 2009 12:28:05 PM UTC, comment #14: |
Simon Goldschmidt <goldsimon> |
Thu 23 Apr 2009 07:27:08 AM UTC, comment #13: I've been running Oleg's code since 2008-Nov, and lwip still works well in my device. So it seems it has good (or at least no bad) impact for our scenarios. |
Tamas Somogyi <tsomogyi> |
Wed 22 Apr 2009 07:26:27 PM UTC, comment #12: I'd also prefer sort on insert. The code in comment #3 looks OK to me, the only question is how to test it without completing task #7930... I'm not in a position to really test the impact of this change :-( |
Simon Goldschmidt <goldsimon> |
Wed 22 Apr 2009 08:13:19 AM UTC, comment #11: I like Oleg's approach of inserting the packet in the right place rather than having to sort the queue later. |
Kieran Mansley <kieranm> |
Tue 21 Apr 2009 08:21:57 PM UTC, comment #10: Kieran, what's your opinion on this? In my opinion, sorting the queues is the right thing to do, although it's not me who's the expert on lwIP's TCP code... |
Simon Goldschmidt <goldsimon> |
Fri 03 Apr 2009 10:53:39 AM UTC, comment #9: Just to recap, this bug is concerning badly order tcp queues, for which Oleg suggests a fix in comment #3 |
Kieran Mansley <kieranm> |
Thu 27 Nov 2008 12:06:38 PM UTC, comment #8: It seems that my problem is not related to this issue indeed, but to bug #20511, which is about Zero Window Probe. More explanation follow in that bugtrack soon. |
Tamas Somogyi <tsomogyi> |
Fri 21 Nov 2008 04:15:38 PM UTC, comment #7: The person most likely to investigate is probably me, and I'm snowed under with other work at the moment. If you need a quick solution, you'll have to investigate further yourself, much like the case for the start of this bug report. I appreciate that this is not ideal, but I think it better that I say that I don't have time, rather than claim I do and then do nothing! |
Kieran Mansley <kieranm> |
Fri 21 Nov 2008 04:11:29 PM UTC, comment #6: Perhaps a different bug indeed, but very close to it: must be something with retransmission and acknowledge handling. What to do now: shall I expect somebody among LwIP developers to investigate or I'd rather open a new bug track? |
Tamas Somogyi <tsomogyi> |
Fri 21 Nov 2008 10:59:18 AM UTC, comment #5: If fully sorting the list doesn't solve your problem, this is a different bug. |
Kieran Mansley <kieranm> |
Fri 21 Nov 2008 10:42:16 AM UTC, comment #4: Hi,
|
Tamas Somogyi <tsomogyi> |
Mon 22 Sep 2008 04:57:17 PM UTC, comment #3: In time I tested fastretransmit I had the same problem with unordered queues.
|
Oleg Tyshev <olegreen> |
Sat 06 Sep 2008 08:57:37 AM UTC, comment #2: tcp_output not sending because of (tcp_input_pcb == pcb) is clearly a problem, but could the nagel algorithm (which was introduced in 1.3.0) also be a problem here? Since it wouldn't cause problems without the (tcp_input_pcb == pcb) problem, I think it's not the cause of this bug.
|
Simon Goldschmidt <goldsimon> |
Sat 06 Sep 2008 08:48:46 AM UTC, comment #1: And a reply from Kieran:
|
Simon Goldschmidt <goldsimon> |
Sat 06 Sep 2008 08:44:51 AM UTC, original submission:
Hans-Joerg Wagner found this, posted on lwip-users:
|
Simon Goldschmidt <goldsimon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 20 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-04-26 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-04-03 | kieranm | Planned Release | 1.3.1 | ||
2008-11-21 | tsomogyi | Attached File | - | Added 750-850.1.3.0.pcap, #16889 | |
Attached File | - | Added 9700-9746.1.3.0.pcap, #16890 | |||
Carbon-Copy | - | Added tsomogyi |
Powered by Savane 3.13-758e.
Corresponding source code
I've had a quick look over what Oleg suggested in comment #3 and checked it in, since it seems to work.