bugvile, a vi-compatible text editor - Bugs: bug #24436, incremental-search causes first...

 
 

bug #24436: incremental-search causes first backspace to remove 2 chars

Submitted by:  David Rolfe <dsrolfe>
Submitted on:  Thu 02 Oct 2008 08:46:23 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 May 2009 12:10:18 AM UTC, comment #4:

This was fixed in 9.7f (20081019)

Thomas Dickey <dickey>
Project Administrator
Wed 08 Oct 2008 03:02:48 PM UTC, comment #3:

Hi Tom,

Thanks for the fast reply and excellent work on VILE. I love this editor!

BTW did you mean to type 9.7e rather than 9.7f? I haven't seen 9.7e yet and I wonder if this was a type-o.

David Rolfe <dsrolfe>
Tue 07 Oct 2008 11:16:17 PM UTC, comment #2:

It seems to be an off-by-one in replaying the accumulated
pattern - fix in isearch.c with this chunk:

@@ -99,7 +100,7 @@
/* See if we're re-executing: */

if (cmd_reexecute >= 0
- && (cmd_reexecute + 1) < (int) itb_length(cmd_buff)) {
+ && (cmd_reexecute + 1) <= (int) itb_length(cmd_buff)) {
c = itb_values(cmd_buff)[cmd_reexecute++];
} else {
/* We're not re-executing (or aren't any more). Try for a real char */

That'll be in 9.7f (I'm in the middle of some unrelated changes,
considering whether/how to show highlighting in incremental
search).

Thomas Dickey <dickey>
Project Administrator
Sun 05 Oct 2008 11:26:37 PM UTC, comment #1:

I can reproduce this (thanks)

Thomas Dickey <dickey>
Project Administrator
Thu 02 Oct 2008 08:46:23 PM UTC, original submission:

Hi,

When using an incremental search, if I type in my search string and make a mistake, the first time I hit the backspace character, it removes 2 characters rather than one. The second backspace character takes out one space.

I enable incremental-search with this line in my ~/.vilerc file:

bind-key incremental-search /

This happens on both my Tru64 Alpha and my Solaris 2.9 machines using vile version 9.7d

Conctact me if you need more information.

David Rolfe <dsrolfe>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dickey (Posted a comment)
  • -unavailable- added by dsrolfe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 May 2009 12:10:28 AM UTCdickeyStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1