buglwIP - A Lightweight TCP/IP stack - Bugs: bug #25575, DHCP does not call autoip_stop in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #25575: DHCP does not call autoip_stop in coop mode

Submitted by:  Jakob Stoklund Olesen <stoklund>
Submitted on:  Fri 13 Feb 2009 09:55:07 AM UTC  
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Sat 02 May 2009 03:41:30 PM UTC, comment #4: 

Done. Thanks for the reminder.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 01 May 2009 05:49:29 PM UTC, comment #3: 

Sorry, seems like I didn't read the whole post, only the summary :-/

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 01 May 2009 12:54:47 PM UTC, comment #2: 

Thanks for fixing this.

I don't know if anybody ever calls dhcp_stop, but technically you need to insert a snippet in that function too.

I never call dhcp_stop(), so I am all good...

Jakob Stoklund Olesen <stoklund>
Project Member
Fri 01 May 2009 12:15:28 PM UTC, comment #1: 

Already fixed when integrating patch #6721 (dhcp.c v1.93)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 13 Feb 2009 09:55:07 AM UTC, original submission:  

When using LWIP_DHCP_AUTOIP_COOP, the DHCP code may call autoip_start. When this has happened, autoip_stop should also be called when:

  • dhcp_bind overrides the AutoIP address
  • dhcp_stop closes the interface

The first case is handled by patch #6721. The second case can be handled in the same way by inserting

#ifdef LWIP_DHCP_AUTOIP_COOP
  if(dhcp->autoip_coop_state == DHCP_AUTOIP_COOP_STATE_ON) {
    autoip_stop(netif);
    dhcp->autoip_coop_state = DHCP_AUTOIP_COOP_STATE_OFF;
  }
#endif /* LWIP_DHCP_AUTOIP_COOP */

into dhcp_stop.

Jakob Stoklund Olesen <stoklund>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by stoklund (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-05-02 goldsimon StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2009-05-01 goldsimon Planned Release => 1.3.1
    2009-05-01 goldsimon StatusFixed => In Progress
        Open/ClosedClosed => Open
    2009-05-01 goldsimon StatusNone => Fixed
        Assigned toNone => goldsimon
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5