bugWeeChat - Bugs: bug #26110, /layout apply doesnt order buffers...

 
 

bug #26110: /layout apply doesnt order buffers properly when some of them are missing

Submitted by:  None
Submitted on:  Tue Apr 7 17:11:31 2009  
Votes:  1  
 
Category: core commandsSeverity: 3 - Normal
Item Group: commandStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: sleoOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 0.3.0
IRC nick: sleo

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Aug 5 11:57:12 2011, comment #6:

Should be definitely fixed!

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon Dec 27 13:26:31 2010, comment #5:

I'd like to add that merged buffer states currently aren't restored either (possibly due to non-consecutive buffer numbers not being supported?).

Currently I am using an alias on start-up for this instead where I move the primary buffer I want to merge with to a specific number, next I merge the other buffers using the previously specified number and then apply the layout:
It might not be clean, but it is a workaround that works for me in the mean time.

Filip H.F. "FiXato" Slagter <fixato>
Wed Mar 31 05:54:29 2010, comment #4:

In fact "/layout apply" is never called by WeeChat. But when a buffer is opened (when you join a channel for example), WeeChat will choose number for this buffer, according to layout number saved (but only for this buffer, not other buffers like /layout apply does).
If you want to force a /layout apply, I think you can set a server command like that:
/set irc.server.freenode.command "/wait 30 /layout apply"
Or a command at startup:
/set weechat.startup.command_after_plugins "/wait 30 /layout apply"
Maybe this should be done in an automatic way, I'll think about that.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue Mar 30 20:50:20 2010, comment #3:

So, I cherrypicked your commit (http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commit;h=56526db5cf0df2b115b377db82ed3b064396790b).

It seems to fix the 3 /layout apply issue I had to do, so, that's sweet :)
Well, as you told, there is still the issue as I think the /layout is called before I'm connected to my 3 IRC server (freenode, gimp.net and debian one). Can we delay the first /layout call to apply once connected, with a timeout of 30s?

Thanks again for that fix.

Didier Roche <didrocks>
Mon Mar 29 14:33:10 2010, comment #2:

Ready for test, please keep me informed if this is working fine now.
Another problem of infinite loop with /layout apply was fixed too.

For initial problem (when there are not enough buffers), more changes are needed because non consecutive numbers are not allowed today. Maybe this will change in future, but this is not really a bug, but would be a new feature.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Sat Jan 16 19:34:16 2010, comment #1:

As already reported on bug #28635, I have the same bug and need to run /layout apply 3 times before getting the right order (this is each time reproducible).

Opening each buffer and then /layout apply doesn't work in my case.

For the record, my setup is the following:
- one bip daemon on my server, connected to 3 IRC servers (freenode, gnome,
debian), exporting 3 network.

Before opening weechat, my .weechat/weechat.conf contains:
[layout]
buffer = "core;weechat;1"
buffer = "irc;server.bip-freenode;1"
buffer = "irc;server.bip-gnome;1"
buffer = "irc;server.bip-debian;1"
buffer = "irc;bip-freenode.#ubuntu-desktop;2"
buffer = "irc;bip-freenode.#ubuntu-devel;3"
buffer = "irc;bip-freenode.#ubuntu-motu;4"
buffer = "irc;bip-freenode.#ubuntu-fr-devel;5"
buffer = "irc;bip-freenode.#quickly;6"
buffer = "irc;bip-freenode.#ubuntu-fr-admins;7"
buffer = "irc;bip-freenode.#ubuntu-fr-party;8"
buffer = "irc;bip-gnome.#gnome;9"
buffer = "irc;bip-gnome.#gnome-love;10"
buffer = "irc;bip-gnome.#gnomefr;11"
buffer = "irc;bip-gnome.#gdm;12"
buffer = "irc;bip-debian.#debian-gnome;13"
window = "1;0;0;0;irc;server.bip-debian"

Opening weechat gave me the following layout (save with /layout save all or
automatically one close):
[layout]
buffer = "core;weechat;1"
buffer = "irc;server.bip-freenode;1"
buffer = "irc;server.bip-gnome;1"
buffer = "irc;server.bip-debian;1"
buffer = "irc;bip-freenode.#ubuntu-desktop;2"
buffer = "irc;bip-gnome.#gdm;3"
buffer = "irc;bip-freenode.#ubuntu-motu;4"
buffer = "irc;bip-freenode.#ubuntu-devel;5"
buffer = "irc;bip-freenode.#ubuntu-fr-devel;6"
buffer = "irc;bip-gnome.#gnome;7"
buffer = "irc;bip-gnome.#gnomefr;8"
buffer = "irc;bip-freenode.#ubuntu-fr-party;9"
buffer = "irc;bip-freenode.#ubuntu-fr-admins;10"
buffer = "irc;bip-gnome.#gnome-love;11"
buffer = "irc;bip-freenode.#quickly;12"
buffer = "irc;bip-debian.#debian-gnome;13"
window = "1;0;0;0;irc;server.bip-debian"

Didier Roche <didrocks>
Tue Apr 7 17:11:31 2009, original submission:

To reproduce,
start clean weechat install
/connect -all (to the default freenode server)

server window:
/query weetest000
/join #weetest001
/join #weetest002
/layout save
/save
/quit

start weechat again, this time we dont open the query buffer

/connect -all

server window:
/join #weetest001
/join #weetest002
/buffer
/layout apply
/buffer
/layout apply
/buffer

Every /layout apply will switch the two channels' places shown in /buffer. If there are more channels the order can change even more.

If you now open the query buffer that's missing and then use /layout apply, it works fine.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fixato (Voted in favor of this item)
  • -unavailable- added by fixato (Posted a comment)
  • -unavailable- added by didrocks (Posted a comment)
  • -unavailable- added by flashcode (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 1 encouragement so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Oct 22 10:50:23 2011flashcodeOpen/ClosedOpen=>Closed
    Fri Aug 5 11:57:12 2011flashcodeStatusReady For Test=>Fixed
    Tue Jan 18 23:52:09 2011fixatoCarbon-Copy-=>Added fixato
    Mon Mar 29 14:33:10 2010flashcodeStatusPostponed=>Ready For Test
    Fri Jan 15 18:03:29 2010flashcodeStatusIn Progress=>Postponed
    Wed Sep 16 08:42:17 2009flashcodeRelease1.8-dev=>0.3.0
    Sat Jul 4 13:57:06 2009flashcodeStatusNone=>In Progress
      Assigned toNone=>flashcode

    Back to the top


    Powered by Savane 3.1-cleanup1