buglwIP - A Lightweight TCP/IP stack - Bugs: bug #26135, Don’t need to allocate space for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26135: Don’t need to allocate space for link header since already in etharp_hdr.

Submitter:  Zhenwei Chu <blackfin>
Submitted:  Thu 09 Apr 2009 02:21:42 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  kieranm
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.3.0

Wed 15 Apr 2009 02:37:29 PM UTC, comment #3: 

In fact, this is already done: I converted it from PBUF_LINK to PBUF_RAW (saving space, initial post is the other way round, which is wrong) in etharp.c v1.150, 7 weeks ago -> fixed in CVS HEAD but was wrong in 1.3.0.

Kieran, I'll close this, hope it's OK for you as you are the assignee.

Simon Goldschmidt <goldsimon>
Group administrator
Fri 10 Apr 2009 05:59:19 AM UTC, comment #2: 

Please do so. We already talked about that line multiple times and I wanted to change it but I always seem to have forgotten it...

Simon Goldschmidt <goldsimon>
Group administrator
Thu 09 Apr 2009 02:45:39 PM UTC, comment #1: 

Looks good, thanks.  I'll apply this unless anyone has any objections.

Kieran Mansley <kieranm>
Group Member
Thu 09 Apr 2009 02:21:42 PM UTC, original submission:  

Don’t need to allocate space for link header since already in etharp_hdr.

changed
Etharp.c, line1029:
From:
etharp_raw()

  /* allocate a pbuf for the outgoing ARP request packet */
    /* don't need to allocate space for link header since already in etharp_hdr */
    p = pbuf_alloc(PBUF_RAW, sizeof(struct etharp_hdr), PBUF_RAM);


To:
etharp_raw()

  /* allocate a pbuf for the outgoing ARP request packet */

  p = pbuf_alloc(PBUF_LINK, sizeof(struct etharp_hdr), PBUF_RAM);


Zhenwei Chu <blackfin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by blackfin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-15 goldsimon StatusNone Fixed
        Open/ClosedOpen Closed
    2009-04-09 kieranm Assigned toNone kieranm
        Planned Release 1.3.1

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code