lwIP - A Lightweight TCP/IP stack - Bugs: bug #26397, SLIP polling support
You are not allowed to post comments on this tracker with your current authentication level.
bug #26397: SLIP polling support
Submitter: | Simon Kallweit <skallweit> | ||
Submitted: | Wed 29 Apr 2009 12:00:26 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Feature Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Jump to the original submission
Fri 28 Aug 2009 08:16:23 AM UTC, comment #14: |
Simon Goldschmidt <goldsimon> |
Thu 27 Aug 2009 07:04:13 AM UTC, comment #13: I have just done some testing of the new SLIP and SIO code. It works perfectly fine for me, both in blocking and polling mode (NO_SYS=0 and NO_SYS=1). Thanks a lot for getting this in. |
Simon Kallweit <skallweit> |
Wed 26 Aug 2009 09:03:38 PM UTC, comment #12: I've just checked in the patches for slipif.c/.h (slightly modified). I do hope it works since I can only compile it, not really test it.
|
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 08:17:30 PM UTC, comment #11: Well, I hope my documentation is right. At least it seemed to make sense looking at the ppp and slip code. The slip patch should be fine with your proposed changes. Thanks |
Simon Kallweit <skallweit> |
Tue 25 Aug 2009 05:58:51 PM UTC, comment #10:
|
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 12:18:04 PM UTC, comment #9: Simon Goldschmidt wrote:
|
Simon Kallweit <skallweit> |
Tue 25 Aug 2009 10:52:14 AM UTC, comment #8:
|
Simon Goldschmidt <goldsimon> |
Tue 25 Aug 2009 09:38:23 AM UTC, comment #7: I thought sio_recv would not block since it is used that way in ppp.c: if it returns 0, nothing has been read and a sleep(1) is executed. If it would block, this would never happen.
|
Simon Goldschmidt <goldsimon> |
Mon 24 Aug 2009 08:57:37 AM UTC, comment #6: Simon, I wonder if it is the right approach to just add a parameter to slipif_input. I think we would first have to clear up on what the sio functions are meant to do. To my guessing all the sio functions are currently meant to be blocking. The sio API does only support aborting a read operation yet, but no non-blocking reads. Would it make sense to introduce for example a function sio_read_nb() to do a non-blocking read?
|
Simon Kallweit <skallweit> |
Sat 22 Aug 2009 10:07:21 PM UTC, comment #5: I had a look at the new patch and it seems the comments referring to the sio_-functions used weren't adjusted.
|
Simon Goldschmidt <goldsimon> |
Fri 21 Aug 2009 07:58:13 AM UTC, comment #4: Thanks for the explanation of the changes, it makes a lot more sense now. I'll try and apply this without the whitespace changes to the copyright message.
|
Kieran Mansley <kieranm> |
Fri 21 Aug 2009 07:56:40 AM UTC, comment #3: Follow-up from Simon Kallweit sent to mailing list copied here:
|
Kieran Mansley <kieranm> |
Thu 20 Aug 2009 02:03:21 PM UTC, comment #2: I don't think there's any particular reason why this has failed to be applied, just that it hasn't been a high priority.
|
Kieran Mansley <kieranm> |
Thu 20 Aug 2009 01:32:03 PM UTC, comment #1: Is there any reason why this patch is not commited? Is it an issue that sio_recv() is used in place of sio_read(), as this could affect users? I'm preparing a new lwIP package for the eCos OS and would like to have support for polled SLIP devices. |
Simon Kallweit <skallweit> |
Wed 29 Apr 2009 12:00:26 PM UTC, original submission:
This patch provides support running the SLIP interface in a polling mode. This can be useful to run lwIP/SLIP in a single thread with NO_SYS=1. The change should not affect current users of SLIP. Some of the memory will be moved from stack to heap, and instead of sio_recv() the patch uses sio_read(). Polling mode can be used by periodically calling slipif_poll(). |
Simon Kallweit <skallweit> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-08-28 | goldsimon | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2009-08-26 | goldsimon | Status | None | Ready For Test | |
Assigned to | None | goldsimon | |||
2009-08-25 | skallweit | Attached File | - | Added sio.patch, #18637 | |
2009-08-21 | kieranm | Planned Release | 1.4.0 | ||
2009-08-20 | skallweit | Attached File | - | Added slipif.c.patch, #18611 | |
Attached File | - | Added slipif.h.patch, #18612 | |||
2009-04-29 | skallweit | Attached File | - | Added slipif_poll.patch, #18052 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Thanks for testing.