lwIP - A Lightweight TCP/IP stack - Bugs: bug #26487, igmp_ip_output_if uses IP_HDRINCL...
You are not allowed to post comments on this tracker with your current authentication level.
bug #26487: igmp_ip_output_if uses IP_HDRINCL at the wrong place
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Thu 07 May 2009 06:09:09 PM UTC | ||
Category: | IPv4 | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Tue 12 May 2009 07:52:55 PM UTC, comment #2: |
Bill Auerbach <billauerbach> |
Tue 12 May 2009 06:00:58 PM UTC, comment #1: As noone objected, I've added ip_output_if_opt() that adds the 2 arguments void* ip_options and u16_t optlen to ip_output_if(). This function is only preprocessor-enabled if LWIP_IGMP=1, so the impact on the rest should be minimal (had to create an u16_t ip_hlen=IP_HLEN, but a good compiler can optimize that away as a constant anyway). |
Simon Goldschmidt <goldsimon> |
Thu 07 May 2009 06:09:09 PM UTC, original submission:
pbuf_header(p, IP_HLEN) is executed even if IP_HDRINCL is given, which results in a wrong payload.
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-05-12 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed |
Powered by Savane 3.13-f8d8.
Corresponding source code
It won't (shouldn't) optimize it without static and/or const.