bugWeeChat - Bugs: bug #27933, destdir support fix

 
 

bug #27933: destdir support fix

Submitted by:  Antoine Reilles <tonio>
Submitted on:  Wed 04 Nov 2009 08:12:19 AM UTC  
 
Category: packagingSeverity: 3 - Normal
Item Group: compile/installStatus: Need Info
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Open/Closed: Open
Release: 0.3.0IRC nick: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 04 Nov 2009 10:18:38 AM UTC, comment #2:

The patch I provided is wrong: it patches the distributed sources so that weechat-0.3.0 can be installed with destdir, but does not patch the files that is used to generate the Makefile.in file.

Attached patch updates the Makefile.am file, which is used to generate the Makefile.in file in the distribution.

(file #18987)

Antoine Reilles <tonio>
Wed 04 Nov 2009 08:28:20 AM UTC, comment #1:

Hi Antoine,

In your patch, you modified file Makefile.in in src/plugins but this file it automatically built (it's not in repository). So I can't apply it.

Moreover, cmake is now recommended way to compile weechat, did you try it?
But anyway bugs will still be fixed in configure/Makefiles since they still exist in git repository.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Wed 04 Nov 2009 08:12:19 AM UTC, original submission:

Hi,

Destdir is not fully supported by the weechat makefiles, as the install-data-hook rule directly refers to $(includedir).

The fix is simple: prepend $(DESTDIR) in fron of $(includedir) in this rule.
This allows to install weechat in destdir, and ease packaging.

best regards,
antoine

Antoine Reilles <tonio>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18990:  0001-fix-destdir-support.patch added by tonio (758B - application/octet-stream - git formatted patch)
file #18987:  weechat.diff added by tonio (398B - application/octet-stream - patch for Makefile.am)
file #18986:  patch-ac added by tonio (631B - application/octet-stream - patch proposition)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Posted a comment)
  • -unavailable- added by tonio (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 04 Nov 2009 10:38:40 PM UTCtonioAttached File-=>Added 0001-fix-destdir-support.patch, #18990
    Wed 04 Nov 2009 10:18:38 AM UTCtonioAttached File-=>Added weechat.diff, #18987
    Wed 04 Nov 2009 08:28:20 AM UTCflashcodeStatusNone=>Need Info
      Assigned toNone=>flashcode
    Wed 04 Nov 2009 08:12:19 AM UTCtonioAttached File-=>Added patch-ac, #18986

    Back to the top


    Powered by Savane 3.1-cleanup