lwIP - A Lightweight TCP/IP stack - Bugs: bug #28241, oos processing
You are not allowed to post comments on this tracker with your current authentication level.
bug #28241: oos processing
Submitter: | Oleg Tyshev <olegreen> | ||
Submitted: | Wed 09 Dec 2009 03:36:48 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | CVS Head |
Jump to the original submission
Fri 08 Jan 2010 03:11:21 PM UTC, comment #17: |
Simon Goldschmidt <goldsimon> |
Sun 27 Dec 2009 11:20:22 AM UTC, comment #16: Unfortunately, there's a bug in the patch from comment #14 which has made it into the 1.3.2 release:
|
Simon Goldschmidt <goldsimon> |
Thu 24 Dec 2009 03:30:42 PM UTC, comment #15: I'm committing both these patches (with a few modifications, references to next->mpTcpHdr for example), although I must confess the second one is a bit hard to follow what it's changing and why.
|
Kieran Mansley <kieranm> |
Tue 15 Dec 2009 01:11:59 PM UTC, comment #14: 2nd patch for processing oos queue after receiving in-sequence segment
|
Oleg Tyshev <olegreen> |
Fri 11 Dec 2009 01:15:29 PM UTC, comment #13: Oh, that makes sense... in that case, the check should be included or we lose the FIN - it might be retransmitted, but that's inefficient.
|
Simon Goldschmidt <goldsimon> |
Fri 11 Dec 2009 11:18:34 AM UTC, comment #12: Ahh, now I understand. The length being used in the comparison (cseg->len) is the payload length, not the sequence length, and so does not include any FIN bits.
|
Kieran Mansley <kieranm> |
Fri 11 Dec 2009 11:03:28 AM UTC, comment #11: It is another question, what should we do when we have data behind the FIN,
|
Oleg Tyshev <olegreen> |
Fri 11 Dec 2009 10:52:12 AM UTC, comment #10: The other end is wrong and we can do what we like. Seqno 5 in the old packet was a FIN, seqno 5 in the new packet is not a FIN. Which is correct? We should probably reset the connection in this case.
|
Kieran Mansley <kieranm> |
Fri 11 Dec 2009 10:45:34 AM UTC, comment #9: May be I have made not correct description
|
Oleg Tyshev <olegreen> |
Fri 11 Dec 2009 10:36:29 AM UTC, comment #8: The FIN uses a byte of sequence space, so if two packets finish on the same sequence byte and one has a FIN and the other does not, that is wrong. I'm happy with the change as Simon has made it. |
Kieran Mansley <kieranm> |
Fri 11 Dec 2009 10:30:32 AM UTC, comment #7: You are right in 4th comment.
|
Oleg Tyshev <olegreen> |
Thu 10 Dec 2009 05:37:49 PM UTC, comment #6: After all, the extra FIN check is not at all necessary, since that case should already be covered by the first line in tcp_oos_insert_segment():
|
Simon Goldschmidt <goldsimon> |
Thu 10 Dec 2009 03:51:09 PM UTC, comment #5: Anyway, I would have expected it to work without the extra check for the FIN flag as that should already be covered by comparing the sequence numbers. |
Simon Goldschmidt <goldsimon> |
Thu 10 Dec 2009 02:27:52 PM UTC, comment #4: That's true, I would have expected somthing like:
|
Simon Goldschmidt <goldsimon> |
Thu 10 Dec 2009 10:46:25 AM UTC, comment #3: I can see what you mean with the GT -> GEQ change, but I don't understand that FIN change:
|
Kieran Mansley <kieranm> |
Thu 10 Dec 2009 10:04:26 AM UTC, comment #2: Suppuse we have rcv_nxt==0
|
Oleg Tyshev <olegreen> |
Wed 09 Dec 2009 07:36:11 PM UTC, comment #1:
|
Simon Goldschmidt <goldsimon> |
Wed 09 Dec 2009 03:36:48 PM UTC, original submission:
In function tcp_oos_insert_segment()
|
Oleg Tyshev <olegreen> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-01-08 | goldsimon | Status | In Progress | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2009-12-27 | goldsimon | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2009-12-24 | kieranm | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2009-12-15 | olegreen | Attached File | - | Added oos_ins2.patch, #19272 | |
2009-12-09 | olegreen | Attached File | - | Added oos_ins.patch, #19226 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Closing this as it doesn't seem too important (for an extra bugfix release).