bugmonotone - Bugs: bug #28372, mtn git_export doesn't specify an...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28372: mtn git_export doesn't specify an "author name"

Submitter:  David Reiss <dreiss>
Submitted:  Tue 22 Dec 2009 03:55:55 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  incorrect behavior Status:  Fixed
Privacy:  Public Assigned to:  dscherger
Open/Closed:  Closed
mtn version --full: 

monotone 0.45 (base revision: a19f8b2017c81c3c6c8b2bb3247f865f6ed4e5a9)
Running on          : Linux 2.6.31-16-generic #53-Ubuntu SMP Tue Dec 8 04:01:29 UTC 2009 i686
C++ compiler        : GNU C++ version 4.4.1
C++ standard library: GNU libstdc++ version 20091005
Boost version       : 1_38
SQLite version      : 3.6.16 (compiled against 3.6.16)
Lua version         : Lua 5.1
PCRE version        : 7.8 2008-09-05 (compiled against 7.8)
Botan version       : 1.8.6 (compiled against 1.8.6)
Changes since base revision:
format_version "1"

new_manifest [a4583b2d0cae8cb6889b8701543aeb4efc7e1554]

old_revision [a19f8b2017c81c3c6c8b2bb3247f865f6ed4e5a9]

  Generated from data cached in the distribution;
  further changes may have been made.



(Also the version in Ubuntu Karmic)

Tue 27 Apr 2010 07:28:54 AM UTC, comment #2: 

This has been fixed in 280779a51cbfc28b7c59f8fe84dd084035febb5d (0.47)

Thomas Keller <tommyd>
Group administrator
Tue 22 Dec 2009 09:18:15 AM UTC, comment #1: 

Derek, could you please have a look at this? Thanks!

Thomas Keller <tommyd>
Group administrator
Tue 22 Dec 2009 03:55:55 AM UTC, original submission:  

"git help fast-import" says that the format of the author and committer lines should look like:

(´author´ SP <name> SP LT <email> GT SP <when> LF)?
´committer´ SP <name> SP LT <email> GT SP <when> LF

The "SP" means space and "LT" is less than, so an example would be:

author David Reiss <dreiss@facebook.com> 1252135718 -0700
committer David Reiss <dreiss@facebook.com> 1252135718 -0700

But mtn git_export produces something like:

author <somename> 1261452747 +0000
committer <somename> 1261452747 +0000

(this is after running "mtn genkey somename").  The author name (and the space after it) are missing.  git fast-import accepts this (I'm reporting this bug to them), but it produces invalid git objects that cause trouble in the generated repository.

The solution is to produce an author name.  The real name of the author would be best if it is available, but the local part of the email address might be a good fallback.

David Reiss <dreiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tommyd (Posted a comment)
  • -email is unavailable- added by dreiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-27 tommyd StatusNone Fixed
        Open/ClosedOpen Closed
    2009-12-22 tommyd Assigned toNone dscherger

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code