bugWeeChat - Bugs: bug #28650, Don't show notification in...

 
 

bug #28650: Don't show notification in notify.py plugin when current buffer is notified

Submitter:  Didier Roche <didrocks>
Submitted:  Sun 17 Jan 2010 06:00:28 PM UTC
   
 
Category:  scripts Severity:  3 - Normal
Item Group:  other Status:  Invalid
Privacy:  Public Assigned to:  flashcode
Originator Name:  Open/Closed:  Closed
Release:  * 0.3.0 IRC nick:  didrocks
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 18 Jan 2010 08:35:18 AM UTC, comment #4: 

Please join #weechat on irc.freenode.net, we'll help you with API.

Sebastien Helleu <flashcode>
Group administrator
Mon 18 Jan 2010 08:10:19 AM UTC, comment #3: 

Btw, in the plugin API, I wasn't able to find how to catch what the current concerned buffer in
weechat.hook_signal("weechat_pv",...,...) function
(it seems to only be available in weechat.hook_print() callback function, which isn't available for private conversation.

Any thought?

Didier Roche <didrocks>
Mon 18 Jan 2010 08:06:26 AM UTC, comment #2: 

I've submitted it to you as you've already patch the script, so I was thinking you was having some interest in it:
http://www.weechat.org/files/scripts/notify.py

2009-05-02, FlashCode

But well… hope the author will answer.

Didier Roche <didrocks>
Sun 17 Jan 2010 06:11:43 PM UTC, comment #1: 

For support with scripts, please contact scripts author. WeeChat bugs are for core or C plugins only, not scripts (which are third-party contributions).

Feel free to submit updates for scripts if your patch is ok (submit script as a new version, not a patch).

Sebastien Helleu <flashcode>
Group administrator
Sun 17 Jan 2010 06:00:28 PM UTC, original submission:  

I think that we shouldn't notify with python-notify when the current buffer is the one receiving the notification.

My attached patch fix that and can be applied to "notify" script.

However, I can't get the current private buffer receiving the current message from the API to achieve the same in nofify_show_priv signal.
Would be nice because being spam with notification when you are talking with someone privately is not great. (only the first one, when somebody begins to speak to you, until you really get to the corresponding buffer is needed in my opinion). Any idea on that?

Didier Roche <didrocks>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by didrocks (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-23 flashcode Open/ClosedOpen Closed
    2010-01-17 flashcode Categoryplugins scripts
        Item GroupNone other
        StatusNone Invalid
        Assigned toNone flashcode
    2010-01-17 didrocks Attached File- Added don_t_show_on_current_buffer.diff, #19506

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code