bugGNUstep - Bugs: bug #29730, Build attempt when typing 'make...

Group
 
 

bug #29730: Build attempt when typing 'make distclean' twice

Submitter:  Quentin Mathé <qmathe>
Submitted:  Sat 01 May 2010 03:16:59 PM UTC
   
 
Category:  Makefiles Severity:  2 - Minor
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 09 Apr 2017 09:32:45 AM UTC, comment #4: 

I checked .. make distclean repeatedly in base no longer attempts to reconfigure.

Richard Frith-Macdonald <CaS>
Group Member
Mon 30 Jun 2014 12:22:08 PM UTC, comment #3: 

Here is a proposed patch to fix this issue.  While here, I also fixed clean/distclean so that all generated files are deleted.  The comments are probably more verbose than needed, feel free to trim them.

P.S. Tests/base/NSInvocationOperation/GNUmakefile should be removed from the repository.

(file #31642)

Yavor Doganov <yavor>
Sat 08 May 2010 02:10:02 PM UTC, comment #2: 

ok, I understand the problem better. I agree that the fix can wait since it is a small issue.

To be precise… The annoying case is when you type 'make distclean' just before leaving a project directory and later on you return to this directory. When you return, you might type 'svn up && make distclean' to be sure you start on a clean base, but right at this point you get stuck as you described.

Quentin Mathé <qmathe>
Group Member
Tue 04 May 2010 01:06:00 PM UTC, comment #1: 

Thanks Quentin

yes, that's a "known" issue in gnustep-base's makefiles/configure.  It's time to fix it :-)

It works that way because the GNUmakefiles are partially generated by ./configure, so you need to do a full ./configure before you can run any targets - including 'distclean'.

That makes sense for building or installing, but for 'distclean' it doesn't make that much sense.  I find it annoying when you can't complete the ./configure (eg, missing dependency), and you're stuck as you can't go forward and can't even go back to a distclean state because distclean itself requires configure.

There are a number of possible solutions, but I'd need to think a bit.  It's not an urgent issue though, may even be prudent to fix it after the release.

Suggestions (if anyone has any) are welcome. :-)

Thanks

Nicola Pero <nico>
Group Member
Sat 01 May 2010 03:16:59 PM UTC, original submission:  

If I build and clean GNUstep Base svn trunk with:
./configure && make && make distclean && make distclean

The last 'make distclean' invocation appear to re-run ./configure when I expect it to do nothing.

I haven't tested it, but I suppose the same issue exists in GNUstep GUI and Back.

Quentin.

Quentin Mathé <qmathe>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #31642:  fix-distclean.patch added by yavor (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by yavor (Updated the item)
  • -email is unavailable- added by nico (Posted a comment)
  • -email is unavailable- added by qmathe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-04-09 CaS StatusNone Fixed
        Open/ClosedOpen Closed
    2014-06-30 yavor Attached File- Added fix-distclean.patch, #31642

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code