bugFonty Python - Bugs: bug #34293, fix hardcoded errno values

 
 

bug #34293: fix hardcoded errno values

Submitted by:  Pino Toscano <pinotree>
Submitted on:  Wed 14 Sep 2011 05:56:05 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Donn Ingle <donningle>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 Apr 2012 12:51:20 PM UTC, comment #1:

Applied your patch. Many thanks. Sorry it took so long.

Donn Ingle <donningle>
Project AdministratorIn charge of this item.
Wed 14 Sep 2011 05:56:05 PM UTC, original submission:

Currently fontypython compares some 'errno' values with hardcoded numeric values, instead of using the constants of the 'errno' Python module.
This can lead to bugs due to E* values being potentially different per-OS, and even per-arch for the same OS.

The attached patch (made against current SVN trunk r167) fixes the issues (adjusting slightly the comments too).

Pino Toscano <pinotree>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23976:  errno.diff added by pinotree (2kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by donningle (Posted a comment)
  • -unavailable- added by pinotree (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 14 Apr 2012 12:51:20 PM UTCdonningleStatusNone=>Fixed
      Assigned toNone=>donningle
    Wed 14 Sep 2011 05:56:05 PM UTCpinotreeAttached File-=>Added errno.diff, #23976

    Back to the top


    Powered by Savane 3.1-cleanup