bugfastcgi++ - Bugs: bug #34341, call to setupSignals is not...

 
 
Show feedback again

bug #34341: call to setupSignals is not necessary when running aside of the web server

Submitted by:  Smeesters Olivier <osmeest>
Submitted on:  Tue 20 Sep 2011 09:16:04 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Ready For Test
Privacy: PublicAssigned to: Eddie Carle <eddic>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 21 Sep 2011 01:38:44 AM UTC, comment #1:

Yeah, this has actually caused me problems in the past but it never occurred to me that it should be changed. I've changed the Manager constructor to include a boolean parameter that disables setting up signals.

Eddie Carle <eddic>
Project AdministratorIn charge of this item.
Tue 20 Sep 2011 09:16:04 AM UTC, original submission:

Hi,

When your fastcgi application is running on its own, the web server will not send signals to it. The call to setupSignals() in ManagerPar constructor is then useless.

Moreover, if the library has to be integrated in a wider application that also wants to have signal handlers, this can cause conflicts.

I suggest to make the call conditional:
If fd == 0, the server has probably started the fastcgi application so setupSignals() is probably needed.
If fd != 0, the fastcgi application runs on its own, the server won't send signals, setupSignals() should be avoided. (An explicit call can still be made if the application wants to.)

My 2 cents,

Olivier

Smeesters Olivier <osmeest>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23995:  07-no-setupSignal-on-socket.patch added by osmeest (904B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by eddic (Posted a comment)
  • -unavailable- added by osmeest (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 21 Sep 2011 01:38:44 AM UTCeddicStatusNone=>Ready For Test
      Assigned toNone=>eddic
    Tue 20 Sep 2011 09:16:04 AM UTCosmeestAttached File-=>Added 07-no-setupSignal-on-socket.patch, #23995
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup