buglwIP - A Lightweight TCP/IP stack - Bugs: bug #3466, sockets.c: Usage of sys_sem_new()

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #3466: sockets.c: Usage of sys_sem_new()

Submitter:  None
Submitted:  Mon 05 May 2003 10:10:53 AM UTC
   
 
Category:  sockets/netconn Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  kieranm
Open/Closed:  Closed Planned Release:  None
lwIP version:  None

Wed 28 Feb 2007 01:49:26 PM UTC, comment #2: 

This patch has been applied, so bug should be fixed.  Please review and post any problems.

Kieran Mansley <kieranm>
Group Member
Mon 26 Feb 2007 03:07:27 PM UTC, comment #1: 

This will get fixed when patch #5468 gets applied (real soon now!)

Kieran Mansley <kieranm>
Group Member
Mon 05 May 2003 10:10:53 AM UTC, original submission:  

All calls to sys_sem_wait() in sockets.c are introduced by

if (!...)
  ... = sys_sem_new(1);

except for lwip_accept(), where sys_sem_wait() could be used on non-allocated semaphore.

(Moreover this construction is not thread-save. A task switch could occur between the decision that the semaphore needs creation and the actual call of sys_sem_new.)

Proposal: Allocate the semaphore only once, at lwip startup.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kieranm (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-02-28 kieranm StatusNone Fixed
        Open/ClosedOpen Closed
    2007-02-26 kieranm Assigned toNone kieranm
    2003-05-07 likewise CategoryNone None

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code