bugThe FreeType Project - Bugs: bug #35599, Out-of-bounds read in...

 
 

bug #35599: Out-of-bounds read in _bdf_parse_glyphs (1)

Submitted by:  Mateusz Jurczyk <j00ru>
Submitted on:  Thu 23 Feb 2012 12:30:47 PM UTC  
 
Severity: 3 - NormalItem Group: Crash
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.4.9

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 Feb 2012 07:16:07 AM UTC, comment #1:

Fixed in git, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Thu 23 Feb 2012 12:30:47 PM UTC, original submission:

Crash tested with ftbench, compiled under Ubuntu amd64 with AddressSanitizer (http://code.google.com/p/address-sanitizer/).

Log from ASAN build:

=================================================================
==28810== ERROR: AddressSanitizer heap-buffer-overflow on address 0x7fc9988b9480 at pc 0x571d56 bp 0x7fffdbd8f770 sp 0x7fffdbd8f768
READ of size 1 at 0x7fc9988b9480 thread T0
#0 0x571d56 _bdf_parse_glyphs
#1 0x56a876 _bdf_readstream
#2 0x568a19 bdf_load_font
#3 0x565aad BDF_Face_Init
#4 0x4913e0 open_face
#5 0x4909a3 FT_Open_Face
#6 0x48fd06 FT_New_Face
#7 0x487557 get_face
#8 0x487cb1 main
#9 0x7fc99950dd5d __libc_start_main
0x7fc9988b9480 is located 0 bytes to the right of 1024-byte region [0x7fc9988b9080,0x7fc9988b9480)
allocated by thread T0 here:
#0 0x5c3222 malloc
#1 0x4a0434 ft_mem_qalloc
#2 0x48b3cf ft_mem_alloc
#3 0x4a3012 ft_mem_qrealloc
#4 0x48bccd ft_mem_realloc
#5 0x56a6cd _bdf_readstream
#6 0x568a19 bdf_load_font
#7 0x565aad BDF_Face_Init
#8 0x4913e0 open_face
#9 0x4909a3 FT_Open_Face
#10 0x48fd06 FT_New_Face
#11 0x487557 get_face
#12 0x487cb1 main
#13 0x7fc99950dd5d __libc_start_main
==28810== ABORTING
Stats: 0M malloced (0M for red zones) by 845 calls
Stats: 0M realloced by 3 calls
Stats: 0M freed by 31 calls
Stats: 0M really freed by 0 calls
Stats: 36M (9221 full pages) mmaped in 9 calls
mmaps by size class: 8:16383; 9:8191; 10:4095; 11:2047; 12:1024; 13:512; 14:256; 15:128; 16:64;
mallocs by size class: 8:804; 9:20; 10:7; 11:6; 12:3; 13:1; 14:1; 15:2; 16:1;
frees by size class: 8:18; 9:3; 10:6; 11:2; 12:1; 13:1;
rfrees by size class:
Stats: malloc large: 0 small slow: 10
Shadow byte and word:
0x1ff933117290: fa
0x1ff933117290: fa fa fa fa fa fa fa fa
More shadow bytes:
0x1ff933117270: 00 00 00 00 00 00 00 00
0x1ff933117278: 00 00 00 00 00 00 00 00
0x1ff933117280: 00 00 00 00 00 00 00 00
0x1ff933117288: 00 00 00 00 00 00 00 00
=>0x1ff933117290: fa fa fa fa fa fa fa fa
0x1ff933117298: fa fa fa fa fa fa fa fa
0x1ff9331172a0: fa fa fa fa fa fa fa fa
0x1ff9331172a8: fa fa fa fa fa fa fa fa
0x1ff9331172b0: fa fa fa fa fa fa fa fa

Log from Valgrind:

==28729== Memcheck, a memory error detector
==28729== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==28729== Using Valgrind-3.8.0.SVN and LibVEX; rerun with -h for copyright info
==28729== Command: ./a.out tmp/freetype/10x20gmb.bdf.asan.6.6
==28729==
==28729== Invalid read of size 1
==28729== at 0x434E5E: _bdf_parse_glyphs (freetype2/freetype-2.4.8/src/bdf/bdflib.c:1716)
==28729== by 0x433000: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:722)
==28729== by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28729== by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28729== by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28729== by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28729== by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28729== Address 0x53dc780 is 0 bytes after a block of size 1,024 alloc'd
==28729== at 0x4C2A4D6: malloc (coregrind/m_replacemalloc/vg_replace_malloc.c:263)
==28729== by 0x406CBF: ft_mem_qalloc (freetype2/freetype-2.4.8/src/base/ftutil.c:76)
==28729== by 0x4082D2: ft_mem_alloc (freetype2/freetype-2.4.8/src/base/ftutil.c:55)
==28729== by 0x408404: ft_mem_qrealloc (freetype2/freetype-2.4.8/src/base/ftutil.c:145)
==28729== by 0x408CCA: ft_mem_realloc (freetype2/freetype-2.4.8/src/base/ftutil.c:101)
==28729== by 0x4326A1: BDF_Face_Init (freetype2/freetype-2.4.8/src/bdf/bdflib.c:634)
==28729== by 0x4089B7: open_face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1149)
==28729== by 0x40B362: FT_Open_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:2076)
==28729== by 0x40C58A: FT_New_Face (freetype2/freetype-2.4.8/src/base/ftobjs.c:1211)
==28729== by 0x40235C: get_face (freetype2/ft2demos-2.4.8/src/ftbench.c:624)
==28729== by 0x402660: main (freetype2/ft2demos-2.4.8/src/ftbench.c:752)
==28729==
couldn't load font resource
==28729==
==28729== HEAP SUMMARY:
==28729== in use at exit: 0 bytes in 0 blocks
==28729== total heap usage: 227 allocs, 227 frees, 108,119 bytes allocated
==28729==
==28729== All heap blocks were freed -- no leaks are possible
==28729==
==28729== For counts of detected and suppressed errors, rerun with: -v
==28729== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 4 from 4)

Mateusz Jurczyk <j00ru>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25132:  10x20gmb.bdf.asan.6.6 added by j00ru (35kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Updated the item)
  • -unavailable- added by j00ru (Submitted the item)
  • -unavailable- added by j00ru
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Feb 2012 07:16:07 AM UTCwlStatusNone=>Fixed
      PrivacyPrivate=>Public
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.4.9
    Sat 25 Feb 2012 01:22:11 PM UTCwlAssigned toNone=>wl
    Thu 23 Feb 2012 12:30:47 PM UTCj00ruAttached File-=>Added 10x20gmb.bdf.asan.6.6, #25132
      Carbon-Copy-=>Added j00ru

    Back to the top


    Powered by Savane 3.1-cleanup