bugThe FreeType Project - Bugs: bug #35847, follow up to bug 35833: Commit:...

 
 

bug #35847: follow up to bug 35833: Commit: 58cbc465d2 breaks the incremental interface

Submitted by:  Chris Liddell <chrisl>
Submitted on:  Thu 15 Mar 2012 10:20:10 AM UTC  
 
Severity:  3 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  Werner LEMBERG <wl> Open/Closed:  Closed
Planned Release:  2.4.10

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Mar 2012 06:43:58 AM UTC, comment #3:

Ah, I've misunderstood the logic. Thanks for the additional explanation; I've slightly changed the comment.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Fri 16 Mar 2012 01:45:41 PM UTC, comment #2:

Updated patch attached. Hopefully the comment is detailed enough - let me know if you want a more verbose explanation.

(file #25377)

Chris Liddell <chrisl>
Thu 15 Mar 2012 09:23:12 PM UTC, comment #1:

Thanks for the patch. However, I ask you to add a comment why this test `inverted' (this is, using >= and || instead of < and &&). Otherwise, people like me are trying to `fix' this to have an orthogonal look :-)

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Thu 15 Mar 2012 10:20:10 AM UTC, original submission:

As a follow up to 35833, there is also an error in the loop exit condition in parse_subrs(), patch to follow......

Chris Liddell <chrisl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by chrisl (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    Sat 17 Mar 2012 06:43:58 AM UTC wl StatusNone => Fixed
        Assigned toNone => wl
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 2.4.10
    Fri 16 Mar 2012 01:45:41 PM UTC chrisl Attached File- => Added 0001-Fix-Savannah-bug-35847-v2.patch, #25377
    Thu 15 Mar 2012 10:28:41 AM UTC chrisl Attached File- => Added 0001-Fix-Savannah-bug-35847.patch, #25367

    Back to the top


    Powered by Savane 3.3