buglwIP - A Lightweight TCP/IP stack - Bugs: bug #36424, PPPoED, packets with error message...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #36424: PPPoED, packets with error message tag are silently tossed

Submitter:  Sylvain Rochet <gradator>
Submitted:  Mon 07 May 2012 02:58:50 PM UTC
   
 
Category:  PPP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Thu 22 May 2014 07:41:43 PM UTC, comment #2: 

ppp-new branch merged in master

Sylvain Rochet <gradator>
Group Member
Mon 04 Jun 2012 08:12:33 PM UTC, comment #1: 

Applied in ppp-new branch.

Sylvain Rochet <gradator>
Group Member
Mon 07 May 2012 02:58:50 PM UTC, original submission:  

If a PPPoED message with an optional error message is received, it is silently tossed due to the "goto done;" which goes to the far end of the function.

We can as well use a "goto breakbreak;" or let the loop finish because the message is always the latest tag.

Here is a patch that fix this behavior, it also remove the useless errortag variable and therefore save 4B on the stack.

Sylvain Rochet <gradator>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Updated the item)
  • -email is unavailable- added by gradator (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-05-22 gradator StatusNone Fixed
        Open/ClosedOpen Closed
        Planned Release 1.5.0
    2013-01-14 goldsimon CategoryNone PPP
    2012-05-07 gradator Attached File- Added lwip-pppoed-packet-with-error-message-tag-silently-tossed.patch, #25813

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code