bugSystem V style init programs - Bugs: bug #36528, [PATCH] [bootlogd] Remove handling...

 
 

bug #36528: [PATCH] [bootlogd] Remove handling of special chars; fix per line buffer problem

Submitter:  None
Submitted:  Tue 22 May 2012 08:21:53 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 28 Feb 2018 02:55:05 AM UTC, comment #4: 

This patched has been merged into the development branch and should be in the 2.89 release.

Jesse <newguy>
Group administrator
Thu 11 Oct 2012 01:59:36 PM UTC, comment #3: 

I've done some more tweaking after that comment, but figured this bugtracker was dead so I didn't bother posting.

Current bootlogd as used in Arch Linux can be found here: http://git.server-speed.net/users/flo/bootlogd/

Florian Pritz <bluewind>
Thu 11 Oct 2012 12:50:59 PM UTC, comment #2: 

No idea if this would be correct ... maybe one of the Debian people should have a closer look.  AFAIK from blogd here around decolouring is a major feature as otherwise some of the codes will destroy readability (codes for TERM=linux readed on TERM=xterm)

Dr. Werner Fink <wfink>
Group administrator
Sat 16 Jun 2012 02:38:34 PM UTC, comment #1: 

Turns out I broke some real features here too (like the ringbuffer keeping not yet written lines). Better patch attached.

(file #26047)

Florian Pritz <bluewind>
Tue 22 May 2012 08:21:53 PM UTC, original submission:  

The linebuffer was only 256 chars so longer lines were truncated in the log file.
   
By removing the handling of special chars (for example: /n/r/t) and simply writing everything we read as is to the logfile we fix this bug, make the code much smaller and allow users to write userspace tools that correctly handle rendering.


I've copied bootlogd.c into a personal git repo so the attached patch is made with git rather than svn, but that shouldn't be a problem.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by newguy (Posted a comment)
  • -email is unavailable- added by bluewind (Updated the item)
  • -email is unavailable- added by bluewind
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-28 newguy StatusNone Fixed
        Open/ClosedOpen Closed
    2012-06-16 bluewind Attached File- Added 0001-simplify-writelog.patch, #26047
    2012-05-22 bluewind Carbon-Copy- Added bluewind
    2012-05-22 None Attached File- Added 0001-Remove-handling-of-special-chars-fix-per-line-buffer.patch, #25909

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code