buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37040, [ppp-new] header file location out...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37040: [ppp-new] header file location out of place.

Submitted by:  hanhui <hanhui03>
Submitted on:  Mon 06 Aug 2012 03:57:16 PM UTC  
 
Category:  None Severity:  2 - Minor
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  Sylvain Rochet <gradator>
Open/Closed:  Closed Planned Release:  None
lwIP version:  CVS Head

Sat 18 Aug 2012 08:47:29 PM UTC, comment #5: 

Fixed in ppp-new branch, all headers moved to include/netif/ppp/.

Sylvain Rochet <gradator>
Project MemberIn charge of this item.
Tue 07 Aug 2012 06:56:07 AM UTC, comment #4: 

Oh, right. The win32 port did not add the include path but includes  "../netif/ppp/ppp_impl.h" instead...

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 06 Aug 2012 07:48:55 PM UTC, comment #3: 

Maybe I am wrong, but I guess users were required to include src/netif/ppp/ in order to use pppOpenOverSerial(), pppClose(), ... functions.

Sylvain Rochet <gradator>
Project MemberIn charge of this item.
Mon 06 Aug 2012 07:40:35 PM UTC, comment #2: 

This hasn't been a problem with the "old" ppp stack, as all files referencing ppp.h where in the same directory, or am I wrong?

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 06 Aug 2012 07:00:09 PM UTC, comment #1: 

Yup, this is a known issue, at least known for all users of the PPP stack.

Sylvain Rochet <gradator>
Project MemberIn charge of this item.
Mon 06 Aug 2012 03:57:16 PM UTC, original submission:  

Hi

   many source file that in different directory, include "ppp.h" header file. But ppp.h only in "src/netif/ppp" directory, so we MUST add directory "src/netif/ppp" as a default search directory.

   So I suggest that put ppp.h into "include/lwip" directory, and that all source file which include "ppp.h" must use include "lwip/ppp.h"

   han.hui

hanhui <hanhui03>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by hanhui03 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-08-18 gradator StatusConfirmed => Fixed
        Open/ClosedOpen => Closed
    2012-08-06 gradator Severity3 - Normal => 2 - Minor
        Item GroupCompiler Warning => Change Request
        StatusNone => Confirmed
        Assigned toNone => gradator
        Summary[ppp-new]header file location out of place. => [ppp-new] header file location out of place.

    Back to the top


    Powered by Savane 3.5