buglwIP - A Lightweight TCP/IP stack - Bugs: bug #37893, Unused variables in tcp_out...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37893: Unused variables in tcp_out (tcphdr)

Submitter:  Krzysztof Wesołowski <kwesoly>
Submitted:  Mon 10 Dec 2012 11:16:26 AM UTC
   
 
Category:  TCP Severity:  3 - Normal
Item Group:  Compiler Warning Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.4.0

Mon 14 Jan 2013 08:07:34 PM UTC, comment #1: 

Fixed, thanks for reporting.

BTW: as a result of lwIP's many configuration options, there may be a lot more unused variables in some configurations.

Plus MS Visual Studio 2008 did not report 'tcphdr' as unused because it is assigned (although never read)...

Simon Goldschmidt <goldsimon>
Group administrator
Mon 10 Dec 2012 11:16:26 AM UTC, original submission:  

Some variables are conditionally unused. This causes compiler warning with specific configuration options.

Putting varible declaration and assignments into same conditional directives solves problem.

I have attached patch for such changes in tcp_out.c.

Krzysztof Wesołowski <kwesoly>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #27065:  tcp_out.c.patch added by kwesoly (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kwesoly (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-01-14 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2012-12-10 kwesoly Attached File- Added tcp_out.c.patch, #27065

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code