bugWeeChat - Bugs: bug #38343, Guile script with a hook_modifier...

 
 

bug #38343: Guile script with a hook_modifier on "weechat_print" crashes WeeChat

Submitted by:  None
Submitted on:  Sat 16 Feb 2013 07:19:02 PM UTC  
 
Category: script API pluginsSeverity: 3 - Normal
Item Group: crashStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Justin COriginator Email: -unavailable-
Open/Closed: ClosedRelease: 0.4.0
IRC nick: boxofrox

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Feb 2013 05:57:51 PM UTC, comment #1:

I have split this bug into two bugs (there are two different problems):
- this one is about the crash with hook_modifier on "weechat_print"
- new bug #38350 is about the wrong arguments given to callbacks (list instead of individual arguments).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Sat 16 Feb 2013 07:19:02 PM UTC, original submission:

See attachments for example scripts.

Script "bug-modifier-weechat-print-1.scm"

This script demonstrates a weechat error when trying to invoke the desired callback with individual parameters.

Script "bug-modifier-weechat-print-2.scm"

This script demonstrates a crash when trying to invoke weechat:print after setting the modifier callback.

Script "bug-modifier-weechat-print-3.scm"

This script demonstrates a proper implementation of the weechat_print modifier callback using a single parameter that receives a list of arguments.

Suggested fix: add note to documentation to indicate that, unlike python or c, guile callbacks use a single parameter to receive a list of four arguments.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27470:  bug-modifier-weechat-print-1.scm added by None (720B - text/x-scheme)
file #27471:  bug-modifier-weechat-print-2.scm added by None (327B - text/x-scheme)
file #27472:  bug-modifier-weechat-print-3.scm added by None (248B - text/x-scheme)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Updated the item)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 May 2013 09:01:30 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Tue 19 Feb 2013 09:51:02 PM UTCflashcodeStatusIn Progress=>Fixed
    Tue 19 Feb 2013 05:57:51 PM UTCflashcodeSummaryGuile plugin with a weechat:hook_modifier callback for "weechat_print" fails/crashes with improper callback definition.=>Guile script with a hook_modifier on "weechat_print" crashes WeeChat
    Mon 18 Feb 2013 05:33:15 PM UTCflashcodeStatusNone=>In Progress
      Assigned toNone=>flashcode
    Sat 16 Feb 2013 07:19:02 PM UTCNoneAttached File-=>Added bug-modifier-weechat-print-1.scm, #27470
      Attached File-=>Added bug-modifier-weechat-print-2.scm, #27471
      Attached File-=>Added bug-modifier-weechat-print-3.scm, #27472

    Back to the top


    Powered by Savane 3.1-cleanup