bugGNU Screen - Bugs: bug #38567, [PATCH] exec: fix ':' for stdin

 
 

bug #38567: [PATCH] exec: fix ':' for stdin

Submitter:  Stas Sergeev <stsp>
Submitted:  Fri 22 Mar 2013 11:02:30 AM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  * 5 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Release:  None
Fixed Release:  None Planned Release:  None
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 22 Mar 2013 11:02:30 AM UTC, original submission:  

Hi.

I've found out that ':' for stdin in an exec pattern doesn't
work. The reason is that if '!' is used for stdin, then the
w_pty fd is just duped to the sub process, so that the p_pty
is bypassed. But with ':' there is a relay mechanism via the
p_pty. In order to match the behaviour of the bypassed pty,
the pty must be set to raw mode, which is what the attached
patch does.
Without the attached patch, if the relayed data does not contain
the '\n's, the sub-process will simply receive nothing at all, because
the pty is then line-buffered.

Does the patch look good?

Stas Sergeev <stsp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27651:  0001-exec-fix-for-stdin.patch added by stsp (815B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by stsp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-03-22 stsp Attached File- Added 0001-exec-fix-for-stdin.patch, #27651

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code