buglwIP - A Lightweight TCP/IP stack - Bugs: bug #39226, Validity of netif IPv6 address is...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #39226: Validity of netif IPv6 address is not always checked

Submitter:  Valery Ushakov <uwe>
Submitted:  Tue 11 Jun 2013 12:27:52 AM UTC
   
 
Category:  IPv6 Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  idelamer
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Wed 18 Mar 2015 05:57:33 PM UTC, comment #1: 

fixed, thanks

Ivan Delamer <idelamer>
Group Member
Tue 11 Jun 2013 12:27:52 AM UTC, original submission:  

There are a few places where validity of netif IPv6 address is not checked, usually in a code like this:


for (i = 0; i < LWIP_IPV6_NUM_ADDRESSES; i++) {
  if (ip6_addr_cmp(netif_ip6_addr(netif, i), ...)) {
    ...


Attached patch fixes the few places I found via source code inspection, but while checking this I found some places that do check address validity, but do it with ip6_addr_isvalid().  Appears correct at the first glance, but tentative addresses are not considered ip6_addr_isvalid(), and I think at least in some of those places the tentative addresses are intended to be ok.

Someone with a clue should review that.

My patch goes for conservative !ip6_addr_isinvalid() - just to protect from checking garbage memory.

Valery Ushakov <uwe>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #28289:  valid-ip6-addr.diff added by uwe (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by idelamer (Posted a comment)
  • -email is unavailable- added by goldsimon (Updated the item)
  • -email is unavailable- added by uwe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-18 idelamer StatusNone Fixed
        Assigned toNone idelamer
        Open/ClosedOpen Closed
    2013-06-28 goldsimon Planned Release 1.5.0
    2013-06-11 uwe Attached File- Added valid-ip6-addr.diff, #28289

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code