bugCompact Disc Input and Control Library - Bugs: bug #39353, filename concatenation defect

 
 

bug #39353: filename concatenation defect

Submitter:  Leo Baschy <infrastrug>
Submitted:  Fri 28 Jun 2013 12:50:39 AM UTC
   
 
Category:  None Severity:  1 - Low
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 16 Sep 2013 12:46:35 AM UTC, comment #4: 

Agree.

Looked at it again, and think this is more a question of code readability, choice of variable names and/or comments.

This probably is not an actual defect.

Would be reasonable to close or lower priority.

Leo Baschy <infrastrug>
Mon 16 Sep 2013 12:20:04 AM UTC, comment #3: 

This is low priority until an example of a failure can be shown.

Rocky Bernstein <rocky>
Group administrator
Sun 15 Sep 2013 11:51:15 PM UTC, comment #2: 

While I cannot pinpoint where this would have an effect, I am still suspicious of printing (into a string)


"%s%s/", psz_path, psz_filename


in find_lsn_recurse in iso9660_fs.c.

Relevant search for uses might be


grep -RI "find_lsn" *


Relevant search for similarly suspicious (not necessarily wrong) code might be


grep -RI "%s%s/" *


If no effects of this are known then maybe this doesn't need to be addressed now.  This comment then is merely a hint for investigation in case of future problems.

Leo Baschy <infrastrug>
Sat 29 Jun 2013 05:30:41 PM UTC, comment #1: 

I'll try to look at this when I get a chance. Thanks.

Rocky Bernstein <rocky>
Group administrator
Fri 28 Jun 2013 12:50:39 AM UTC, original submission:  

In git at lib/iso9660/iso9660_fs.c line 1407 I see


snprintf (*ppsz_full_filename, len, "%s%s/", psz_path, psz_filename);


and that seems wrong.

Shouldn't that be


snprintf (*ppsz_full_filename, len, "%s/%s", psz_path, psz_filename);


?

Leo Baschy <infrastrug>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by infrastrug (Submitted the item)
  • -email is unavailable- added by infrastrug
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-22 rocky StatusPostponed Wont Fix
        Open/ClosedOpen Closed
    2013-10-06 rocky StatusNone Postponed
    2013-09-16 rocky Severity5 - Average 1 - Low
    2013-06-28 infrastrug Carbon-Copy- Added infrastrug

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code