bugWeeChat - Bugs: bug #40204, Falsely truncated nicks due to...

 
 

bug #40204: Falsely truncated nicks due to weechat.look.nick_{prefix,suffix}

Submitted by:  None
Submitted on:  Tue 08 Oct 2013 09:36:34 AM UTC  
 
Category: displaySeverity: 3 - Normal
Item Group: displayStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Originator Email: -unavailable-
Open/Closed: ClosedRelease: 0.4.2
IRC nick: zralb

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Oct 2013 02:22:38 PM UTC, comment #2:

The problem was not on display, but when filters are toggled.
The patch added some display bugs, prefix was shifted by some chars on the right.
So the fix is to compute again the "prefix_max_length" in buffer when filters are toggled.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 14 Oct 2013 07:24:30 AM UTC, comment #1:

Attached is a diff that should fix the root if the problem, if I understood all the prefix calculation code correctly.

I believe that 'prefix_length' already contains 'length_nick_prefix_suffix', so there's no need to subtract it again. Subtracting it leads to nickname truncation, as num_spaces will always be < 0.

(file #29372)

Anonymous
Tue 08 Oct 2013 09:36:34 AM UTC, original submission:

Though weechat.look.prefix_align_max being set to 0, nicks get truncated when weechat.look.nick_prefix or weechat.look.nick_suffix is set to something non empty.

How to reproduce:
/set weechat.look.nick_prefix "<"
and trigger a "redraw", for example by en-/disabling filters (Alt-=).
You should see nicks being truncated though all alignment related options wouldn't trigger this. I don't know another way to trigger the redrawing.

Setting weechat.look.nick_prefix to "" (which is the preset) instantly "untruncates" the nicks.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Feb 2014 09:41:50 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Sat 19 Oct 2013 02:22:38 PM UTCflashcodeItem GroupNone=>display
      StatusNone=>Fixed
      Assigned toNone=>flashcode
    Mon 14 Oct 2013 07:24:30 AM UTCNoneAttached File-=>Added 0001-Correct-alignment-with-look.nick_-prefix-suffix.patch, #29372

    Back to the top


    Powered by Savane 3.1-cleanup