bugWeeChat - Bugs: bug #41640, [PATCH] irc_message_parse requires...

 
 

bug #41640: [PATCH] irc_message_parse requires '!' in prefix

Submitter:  Felix Eckhofer <tribut>
Submitted:  Wed 19 Feb 2014 06:35:51 PM UTC
   
 
Category:  irc plugin Severity:  3 - Normal
Item Group:  irc protocol Status:  Fixed
Privacy:  Public Assigned to:  flashcode
Originator Name:  Open/Closed:  Closed
Release:  * 0.4.3 IRC nick:  vendor
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 20 Feb 2014 07:59:56 AM UTC, comment #1: 

Merged with a small change: check that pos is not NULL in the condition, so that it works with malformed messages where there is nothing after nick/host.

Sebastien Helleu <flashcode>
Group administrator
Wed 19 Feb 2014 06:35:51 PM UTC, original submission:  

Both RFC1459 and RFC2812 allow the prefix in an IRC message to only contain nick and host, such as ":nick@host PRIVMSG #weechat :foo". irc_message_parse will in this case use "nick@host" as nick instead of just "nick".

Reference (from RFC2812):

message    =  [ ":" prefix SPACE ] command [ params ] crlf
prefix     =  servername / ( nickname [ [ "!" user ] "@" host ] )


See the attached patch for my proposed fix. Alternatively, feel free to merge the parse-privmsg branch from my repository at https://github.com/tribut/weechat.git

Thanks!

Felix Eckhofer <tribut>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by tribut (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-08-15 flashcode Open/ClosedOpen Closed
    2014-02-20 flashcode StatusNone Fixed
        Assigned toNone flashcode
        Release3.3-dev 0.4.3
    2014-02-19 tribut Attached File- Added 0001-irc-make-optional-in-message-prefix.patch, #30608

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code