buglwIP - A Lightweight TCP/IP stack - Bugs: bug #41686, ipv4 ip_reass() crash error

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #41686: ipv4 ip_reass() crash error

Submitter:  hanhui <hanhui03>
Submitted:  Tue 25 Feb 2014 11:02:38 AM UTC
   
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Crash Error Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Mon 19 May 2014 08:08:13 PM UTC, comment #3: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 17 May 2014 11:49:32 AM UTC, comment #2: 

I mentioned this problem in https://savannah.nongnu.org/bugs/?41041#comment4 - it's a regression introduced by the fix to that bug.

The loop should actually end with ipr_prev = ipr->next :)

Valery Ushakov <uwe>
Fri 16 May 2014 08:02:12 PM UTC, comment #1: 

Are you sure the patch below is complete? I would have thought the 'for' line should end with

  ipr_prev = ipr_prev->next

not

  ipr = ipr->next

to prevent having an endless loop?

Simon Goldschmidt <goldsimon>
Group administrator
Tue 25 Feb 2014 11:02:38 AM UTC, original submission:  

ip_reass()
{
   ...;
   /* find the previous entry in the linked list */
   for (ipr_prev = reassdatagrams_ipv4; ipr_prev != NULL; ipr = ipr->next) {
     if (ipr_prev->next == ipr) {
       break;
     }
   }

should be:
  
   /* find the previous entry in the linked list */
   if (ipr == reassdatagrams_ipv4) {
     ipr_prev = NULL;
   } else {
     for (ipr_prev = reassdatagrams_ipv4; ipr_prev != NULL; ipr = ipr->next) {
       if (ipr_prev->next == ipr) {
         break;
       }
     }
   }
}

Han.hui

hanhui <hanhui03>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by uwe (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by hanhui03 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-05-19 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code