buglwIP - A Lightweight TCP/IP stack - Bugs: bug #43514, SMTP authentication disabled when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43514: SMTP authentication disabled when only LOGIN is enabled

Submitter:  Uli Köhler <ulikoehler>
Submitted:  Sat 01 Nov 2014 11:48:58 PM UTC
   
 
Category:  Contrib Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  1.4.1

Sun 02 Nov 2014 07:15:50 PM UTC, comment #1: 

Fixed, thanks for reporting.

Simon Goldschmidt <goldsimon>
Group administrator
Sat 01 Nov 2014 11:48:58 PM UTC, original submission:  

In lwip-contrib/apps/smtp/smtp.c (verified in git head and STABLE-1_4_1), several code blocks including smtp_prepare_auth_or_mail() are enabled/disabled using the following macro:

#if SMTP_SUPPORT_AUTH_AUTH || SMTP_SUPPORT_AUTH_LOGIN

I believe this is a typo and it should read:

#if SMTP_SUPPORT_AUTH_PLAIN || SMTP_SUPPORT_AUTH_LOGIN

because SMTP_SUPPORT_AUTH_AUTH is defined nowhere and it clearly makes sense to enable the code blocks if any of the both auth methods are enabled.

I'm trying to run the SMTP client with LOGIN auth disabled and my mailserver shows that no authentication attempt is performed.

Suggested fix:

Replace all occurences of "SMTP_SUPPORT_AUTH_AUTH" with "SMTP_SUPPORT_AUTH_PLAIN" in smtp.c.

Uli Köhler <ulikoehler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by ulikoehler (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-02 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code