buglwIP - A Lightweight TCP/IP stack - Bugs: bug #43904, ip_route() and ip6_route() must...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43904: ip_route() and ip6_route() must detect linkup status.

Submitter:  hanhui <hanhui03>
Submitted:  Tue 30 Dec 2014 05:42:25 AM UTC
   
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Wed 18 Mar 2015 07:26:02 PM UTC, comment #5: 

OK. In that case, I'd leave it as it is now.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 18 Mar 2015 05:35:55 PM UTC, comment #4: 

I don't think so. In general that case should never trigger. For link-local we should always have a source address. This is either done by the user, or the stack chooses one using ip6_select_source_address() on a given netif.

Probably we should even eliminate that case and return ERR_RTE.

Ivan Delamer <idelamer>
Group Member
Wed 18 Mar 2015 05:09:32 PM UTC, comment #3: 

From reading the diff, it looks like link-local packets where the source address is ANY would be dropped when the default netif is down. I'm not saying this is wrong, but would it make sense to send them to any other netif instead?

Simon Goldschmidt <goldsimon>
Group administrator
Wed 18 Mar 2015 04:56:32 PM UTC, comment #2: 

fixed ip6 part.

Ivan Delamer <idelamer>
Group Member
Mon 09 Mar 2015 08:36:39 PM UTC, comment #1: 

Fixed the IPv4 part.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 30 Dec 2014 05:42:25 AM UTC, original submission:  

Hi Simon

   ip_route() select netif only detect netif_is_up(), I suggest that add netif_is_link_up() detect.

   ip6_route() did not even detect the state of the network interface.


   Han.hui

hanhui <hanhui03>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by idelamer (Posted a comment)
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by hanhui03 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-18 idelamer StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2015-03-09 goldsimon StatusNone In Progress
        Assigned toNone goldsimon

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code