bugGPSD - Bugs: bug #43953, Incorrect uses of "safe"...

 
 

bug #43953: Incorrect uses of "safe" string functions

Submitter:  Zbigniew Chyla <zchyla_nokia>
Submitted:  Thu 08 Jan 2015 04:07:08 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 08 Jan 2015 04:07:08 PM UTC, original submission:  

I've found a few incorrect uses of "safe" string functions (strncmp, strncat, strncpy, strlcat, strlcpy), which void protection against overflows these functions are supposed to provide.

See details in the attachments.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32791:  0006-Replace-the-last-strncat-call-with-strlcat.patch added by zchyla_nokia (907B - text/x-patch - [PATCH 6/6] Replace the last strncat call with strlcat)
file #32790:  0005-Fix-incorrect-use-of-strlcpy.patch added by zchyla_nokia (967B - text/x-patch - [PATCH 5/6] Fix incorrect use of strlcpy)
file #32789:  0004-Replace-incorrect-use-of-strncpy-with-strlcpy.patch added by zchyla_nokia (763B - text/x-patch - [PATCH 4/6] Replace incorrect use of strncpy with strlcpy)
file #32788:  0003-Replace-incorrect-use-of-strncat-with-strlcat.patch added by zchyla_nokia (731B - text/x-patch - [PATCH 3/6] Replace incorrect use of strncat with strlcat)
file #32787:  0002-Fix-incorrect-use-of-strlcat.patch added by zchyla_nokia (771B - text/x-patch - [PATCH 2/6] Fix incorrect use of strlcat)
file #32786:  0001-Fix-incorrect-string-size-passed-to-strncmp.patch added by zchyla_nokia (787B - text/x-patch - [PATCH 1/6] Fix incorrect string size passed to strncmp)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by zchyla_nokia (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-22 esr Open/ClosedOpen Closed
    2015-01-13 esr StatusNone Fixed
        Assigned toNone esr
    2015-01-08 zchyla_nokia Attached File- Added 0006-Replace-the-last-strncat-call-with-strlcat.patch, #32791
    2015-01-08 zchyla_nokia Attached File- Added 0005-Fix-incorrect-use-of-strlcpy.patch, #32790
    2015-01-08 zchyla_nokia Attached File- Added 0004-Replace-incorrect-use-of-strncpy-with-strlcpy.patch, #32789
    2015-01-08 zchyla_nokia Attached File- Added 0003-Replace-incorrect-use-of-strncat-with-strlcat.patch, #32788
    2015-01-08 zchyla_nokia Attached File- Added 0002-Fix-incorrect-use-of-strlcat.patch, #32787
    2015-01-08 zchyla_nokia Attached File- Added 0001-Fix-incorrect-string-size-passed-to-strncmp.patch, #32786

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code