bugGPSD - Bugs: bug #44921, Unnecessary memcpy() calls for...

 
 

bug #44921: Unnecessary memcpy() calls for copying structs

Submitter:  Zbigniew Chyla <zchyla_nokia>
Submitted:  Fri 24 Apr 2015 04:41:36 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 24 Apr 2015 04:41:36 PM UTC, original submission:  

When preparing a fix for #44919, I noticed that there're many other ocurrences of copying structs using memcpy() instead of simple assignment, which is more concise and type-safe.

The attached patch replaces memcpy() calls with assignments.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by zchyla_nokia (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-06-03 esr Open/ClosedOpen Closed
    2015-04-28 esr StatusNone Fixed
        Assigned toNone esr
    2015-04-24 zchyla_nokia Attached File- Added 0001-Copy-structs-using-assignment-not-memcpy.patch, #33774

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code