buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45027, Unix echop: option --debug does...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45027: Unix echop: option --debug does not work

Submitter:  Edgar Bonet <ebonet>
Submitted:  Tue 05 May 2015 03:48:53 PM UTC
   
 
Category:  Platform ports Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Tue 05 May 2015 08:20:19 PM UTC, comment #1: 

Indeed, applied, thank you Edgar.

By the way, we should at some point remove mintapif.* from minimal and use tapif.c instead, they are very close from each other from a quick sight.

There are threads involved but adding #if NO_SYS around them should be enough.

Sylvain Rochet <gradator>
Group Member
Tue 05 May 2015 03:48:53 PM UTC, original submission:  

In the Unix port, both the minimal project (echop) and simhot provide a
--debug option. This option works on simhost but has no effect on echop.

On both projects, the option sets a global variable debug_flags which,
according to the comments, is exported in lwipopts.h. The comment is
correct in simhot, where lwipopts.h contains

    extern unsigned char debug_flags;
    #define LWIP_DBG_TYPES_ON debug_flags

but the variable is not exported in echop.

The attached patch fixes the issue by copying the relevant lines from
unixsim/lwipopts.h into minimal/lwipopts.h.

Edgar Bonet <ebonet>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by ebonet (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-05 gradator StatusNone Fixed
        Open/ClosedOpen Closed
    2015-05-05 ebonet Attached File- Added 0001-Unix-port-fix-debug-option-in-echop.patch, #33926

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code