bugGPSD - Bugs: bug #45083, ppsthread.c:1091: erroneous...

 
 

bug #45083: ppsthread.c:1091: erroneous rejection of PPS

Submitter:  None
Submitted:  Tue 12 May 2015 08:53:12 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  garyemiller
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 05 Jan 2016 01:35:12 AM UTC, comment #1: 

Thanks Anonymous, whoever you are.  A stupid bug on my part.  Fixed in commit a19b22f0fcf087ae516a8ea07d4e710a1bba45dd.

This should be in gpsd 3.16 when it comes out.

Gary E. Miller <garyemiller>
Group administrator
Tue 12 May 2015 08:53:12 AM UTC, original submission:  

The condition on line 1091 of ppsthread.c seems wrong:

1090: } else if ( ( 2 < delay.tv_sec)
1091:  || ( 1 == delay.tv_sec && 100000000 > delay.tv_nsec ) ) {
1092:    /* system clock could be slewing so allow 1.1 sec delay */

Should the comparison not be 100000000 < delay.tv_nsec ?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by garyemiller (Posted a comment)
  • -email is unavailable- added by esr (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-07 esr Open/ClosedOpen Closed
    2016-01-05 garyemiller StatusInvalid Fixed
        Summaryppsthread.c:1091: erroneous rejection of PPS? ppsthread.c:1091: erroneous rejection of PPS
    2016-01-04 esr StatusNone Invalid
        Assigned toNone garyemiller

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code