bugThe FreeType Project - Bugs: bug #45097, ftheader macros should include...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45097: ftheader macros should include freetype2 dir in header name

Submitter:  Rene van Paassen <repa>
Submitted:  Wed 13 May 2015 01:50:42 PM UTC
   
 
Severity:  3 - Normal Item Group:  Hack required
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.6.1

Mon 22 Jun 2015 04:52:08 AM UTC, comment #3: 

Thanks for the report; this is fixed now in the git repository, please test.

Werner LEMBERG <wl>
Group administrator
Sat 06 Jun 2015 04:03:50 AM UTC, comment #2: 

Thanks for you thoughts, to which I basically agree.  I will discuss this issue on the freetype-devel mailing list after the next FreeType release.

Werner LEMBERG <wl>
Group administrator
Wed 13 May 2015 10:15:43 PM UTC, comment #1: 

On second thought, the old behavior with a freetype/ dir would be more convenient.

With the current set-up;
{{{
pkg-config --cflags freetype2
-I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/libpng16
}}}

over 40 files with short names -- and short prefixes, ft or tt -- are added to the compiler's search path. If all libraries would do that, projects with more than just a few libraries become a compilation nightmare. In version 2.5.0 (don't know where the exact change was), most of these files were still under a directory freetype/

Rene van Paassen <repa>
Wed 13 May 2015 01:50:42 PM UTC, original submission:  

I currently have a problem compiling projects with FTGL on Mac OS X, which uses freetype.

FTGL has a header FTGlyph.h, and freetype has a header ftglyph.h. Mac OS X is by default (as is Windows always) not case sensitive in header includes, so these files now clash.

There used to be no problem, because the freetype headers were one level deeper, and the config/ftheader.h file (at least in 2.5.0) had lines like:

#define FT_GLYPH_H  <freetype/ftglyph.h>

the current 2.5.5 freetype (just a minor update), removed the freetype dir, and now:

#define FT_GLYPH_H  <ftglyph.h>

This requires a compile flag that includes the freetype header directory (e.g. -I/usr/include/freetype2). That effectively amounts to dumping the freetype headers in the total pool of headers, which I personally think is bad form.

It would be (much) better to include the directory prefix in the defines, to reduce the possibility of header name clashes, so:

#define FT_GLYPH_H  <freetype2/ftglyph.h>

etc.


Rene van Paassen <repa>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by repa (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-06-22 wl StatusConfirmed Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.6.1
    2015-06-06 wl StatusNone Confirmed
        Assigned toNone wl

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code