buglwIP - A Lightweight TCP/IP stack - Bugs: bug #45454, pbuf_take_at() skips write and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45454: pbuf_take_at() skips write and returns OK if offset is at start of pbuf in chain

Submitter:  Erik Ekman <yarrick>
Submitted:  Wed 01 Jul 2015 11:03:30 AM UTC
   
 
Category:  pbufs Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Wed 05 Aug 2015 06:58:27 PM UTC, comment #4: 

Right: fixed, thanks for reporting :-)

Simon Goldschmidt <goldsimon>
Group administrator
Wed 05 Aug 2015 06:39:43 PM UTC, comment #3: 

This one is also merged. If you don't want the code in patch #8678 you can close that also.

Erik Ekman <yarrick>
Group Member
Wed 01 Jul 2015 11:16:28 AM UTC, comment #2: 

Added new patch which removes the if statement, since it was always true.

(file #34353)

Erik Ekman <yarrick>
Group Member
Wed 01 Jul 2015 11:06:11 AM UTC, comment #1: 

Apply patch #8677 before this one to make test cases run again.
Also look at patch #8678 to clean up the unittest warnings.

Erik Ekman <yarrick>
Group Member
Wed 01 Jul 2015 11:03:30 AM UTC, original submission:  

Off by one in bounds check caused write not to happen if supplied is 0, or buf->len in case of chained pbufs.

Fix is attached, together with test cases to verify it.

Erik Ekman <yarrick>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by yarrick (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-05 goldsimon StatusNone Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2015-07-01 yarrick Attached File- Added v2-Fix-edge-case-in-pbuf_take_at.patch, #34353
    2015-07-01 yarrick Attached File- Added 0001-Fix-off-by-one-in-pbuf_take_at.patch, #34352

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code