buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46093, Move IP6_ROUTE() hook to after LL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46093: Move IP6_ROUTE() hook to after LL processing

Submitter:  Ivan Delamer <idelamer>
Submitted:  Thu 01 Oct 2015 03:28:32 PM UTC
   
 
Category:  IPv6 Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  idelamer
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Sat 05 Mar 2016 01:19:19 PM UTC, comment #2: 

fixed by moving the hook further down

Simon Goldschmidt <goldsimon>
Group administrator
Thu 01 Oct 2015 07:09:24 PM UTC, comment #1: 

The proposed changes looks fine to me (at least for all valid usages of the hook that I could think of).

Simon Goldschmidt <goldsimon>
Group administrator
Thu 01 Oct 2015 03:28:32 PM UTC, original submission:  

ip6_route() starts with a call to LWIP_HOOK_IP6_ROUTE() if defined.

However, this is done before checking if the destination is a link-local address, or an address that matches a configured subnet.

It seems that it would make more sense to have the hook just before the call to nd6_select_router(), after the LL and local subnet processing.

This way, the hook function can work on remote addresses and doesn't need to duplicate the logic for local addresses.


Ivan Delamer <idelamer>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by idelamer (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-05 goldsimon StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code