buglwIP - A Lightweight TCP/IP stack - Bugs: bug #46094, IPv4 routing hook functions should...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46094: IPv4 routing hook functions should be moved

Submitter:  Ivan Delamer <idelamer>
Submitted:  Thu 01 Oct 2015 03:32:39 PM UTC
   
 
Category:  IPv4 Severity:  2 - Minor
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Sat 05 Mar 2016 02:53:33 PM UTC, comment #2: 

Done

Simon Goldschmidt <goldsimon>
Group administrator
Thu 01 Oct 2015 07:14:50 PM UTC, comment #1: 

This change looks good as well. Some strange things people do in their hook function could stop working, but the intention of the hook (allowing to extend routing) will be easier that way.

Maybe loopback traffic should be handled before the hook as well.

Simon Goldschmidt <goldsimon>
Group administrator
Thu 01 Oct 2015 03:32:39 PM UTC, original submission:  

LWIP_HOOK_IP4_ROUTE() is called (if defined) at the beginning of the ip4_route() function.

Maybe this should be moved down to after we check for a match to our configured netifs, but before we check for the default router netif.

This way, the hook function doesn't need to duplicate the checks for local subnet routing.

This only applies to LWIP_HOOK_IP4_ROUTE and not to LWIP_HOOK_IP4_ROUTE_SRC

Ivan Delamer <idelamer>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by idelamer (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-05 goldsimon StatusNeed Info Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code