lwIP - A Lightweight TCP/IP stack - Bugs: bug #46506, nd6_new_router() should check if...
You are not allowed to post comments on this tracker with your current authentication level.
bug #46506: nd6_new_router() should check if router exists in router list first
Submitter: | Zach Smith <zsmith> | ||
Submitted: | Mon 23 Nov 2015 10:32:50 PM UTC | ||
Category: | IPv6 | Severity: | 1 - Wish |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Thu 22 Dec 2016 05:15:11 PM UTC, comment #5: |
Zach Smith <zsmith> |
Thu 15 Dec 2016 08:26:57 AM UTC, comment #4: I've decided to fix this (although the fix is slightly different than suggested) since it should not make much difference in code size and speed.
|
Simon Goldschmidt <goldsimon> |
Wed 16 Mar 2016 03:40:21 PM UTC, comment #3:
|
Simon Goldschmidt <goldsimon> |
Tue 15 Mar 2016 10:21:26 PM UTC, comment #2: Thanks for looking at this.
|
Zach Smith <zsmith> |
Sun 06 Mar 2016 01:58:56 PM UTC, comment #1: Well, strictly spoken, what you are doing is not supported by lwIP (having 2 netifs in the same subnet). In the past, we have not added code that was only needed for this case (and you should not have a problem in the 'one-netif-per-net' case).
|
Simon Goldschmidt <goldsimon> |
Mon 23 Nov 2015 10:32:50 PM UTC, original submission:
I think that nd6_new_router() should possibly check the default_router_list[] to see if the router already exists in the list before adding it. It first checks if there is a neighbor_cache[] entry for the router address passed in. If not, it creates one. Then it marks it as a router and adds an entry to the default_router_list[] (w/o checking if it is already there).
|
Zach Smith <zsmith> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-12-15 | goldsimon | Status | Need Info | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2016-03-06 | goldsimon | Severity | 3 - Normal | 1 - Wish | |
Item Group | Faulty Behaviour | Change Request | |||
Status | None | Need Info | |||
2015-11-23 | zsmith | Attached File | - | Added nd6_new_router_check_exists.patch, #35533 |
Powered by Savane 3.13-f8d8.
Corresponding source code
I tested this and it seems to work for me. I replaced our nd6_new_router() function with your new one and I do not get duplicate routers in the list. Thank you!