bugGNU Octave - Bugs: bug #46637, mxe-octave: update GNU Texinfo to...

 
 

bug #46637: mxe-octave: update GNU Texinfo to version 6

Submitter:  Mike Miller <mtmiller>
Submitted:  Tue 08 Dec 2015 07:36:46 PM UTC
   
 
Category:  Configuration and Build System Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  lostbard
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 20 Apr 2016 04:01:29 PM UTC, comment #23: 

Rik & John:  Thanks for the fix.  I was able to build and execute _run_test_suite_ on a Windows system.  I'll make the 4.0.2 release and the corresponding Windows binary in the next day or so.

John W. Eaton <jwe>
Group administrator
Wed 20 Apr 2016 03:49:55 PM UTC, comment #22: 

Closing report (again!).  jwe can re-open if necessary.

Rik <rik5>
Group administrator
Wed 20 Apr 2016 10:53:24 AM UTC, comment #21: 
John Donoghue <lostbard>
Group Member
Tue 19 Apr 2016 04:41:48 PM UTC, comment #20: 

The patch didn't cause any trouble for me when building with MXE; But, I also didn't have the original problem that jwe did.  I think it is safe to commit this and have jwe test it when he gets back from his travels.

Rik <rik5>
Group administrator
Tue 19 Apr 2016 01:58:10 PM UTC, comment #19: 

Patch attached

(file #36962)

John Donoghue <lostbard>
Group Member
Sun 17 Apr 2016 08:50:24 PM UTC, comment #18: 

The missing semicolon is my fault - looking at src/mingw-texinfo-1-fixes.patch, i missed a semicolon

John Donoghue <lostbard>
Group Member
Sun 17 Apr 2016 05:00:46 PM UTC, comment #17: 

From comment #12, I guess it must have been an artifact that was somehow still there, since after a clean build last night, it isn't created for me either.

It appears to work with just the added semicolon from comment #15.

Looking at the sources, if it cant find the hardcoded prefix, it tries to determine what it should be based on where the file was installed.


John Donoghue <lostbard>
Group Member
Thu 14 Apr 2016 11:44:10 PM UTC, comment #16: 

John: Your makeinfo which you attached contains
lines such as:
my $prefix = '/scratch/jwe/mxe-octave/usr/i686-w64-mingw32';

This may not be what you intended to attach.

Michael Godfrey <godfrey>
Group Member
Thu 14 Apr 2016 05:28:50 PM UTC, comment #15: 

Line 53 is missing a semicolon to terminate the line.


  my $datadir = '/usr/share'


It should be


  my $datadir = '/usr/share';


My installed version of makeinfo from Ubuntu has the semicolon.

Rik <rik5>
Group administrator
Thu 14 Apr 2016 05:02:38 PM UTC, comment #14: 

It's the main makeinfo program from Texinfo 6.  I think it's the same on all platforms.  Anyway, I've attached it below.


(file #36926)

John W. Eaton <jwe>
Group administrator
Thu 14 Apr 2016 04:54:55 PM UTC, comment #13: 

I'm very handy with Perl.  Can you attach the Perl script 'makeinfo' that is causing the problem and I will take a look?

Rik <rik5>
Group administrator
Thu 14 Apr 2016 04:43:31 PM UTC, comment #12: 

I think the files makeinfo and makeinfo.bat are needed.  The first is the perl script and the other is a batch file to run perl using that script.  I don't know where the .exe file came from (left over from a previous build?).  Anyway, it is still not working for me.  I get the error (from perl, I think) about the syntax of the perl script.  So is there a problem with the version of perl we have?  I think we are installing it from msys.  Maybe we should build our own up to date copy?  I don't have any idea how hard that would be.

John W. Eaton <jwe>
Group administrator
Thu 14 Apr 2016 12:53:52 PM UTC, comment #11: 

I misread your instructions and removed makeinfo.exe and makeinfo.bat.  That made sense to me because the new makeinfo is a Perl script.  That failed because Perl scripts aren't directly executable on Windows systems, are they?  I was getting the message


>> __makeinfo__
'makeinfo' is not recognized as an internal or external command,
operable program or batch file.
warning: print_usage: Texinfo formatting filter exited abnormally
warning: called from
    print_usage at line 73 column 5
    __makeinfo__ at line 64 column 5
warning: print_usage: raw Texinfo source of help text follows...
error: Invalid call to __makeinfo__.  Correct usage is:


Then I went back and did "make texinfo" to rebuild the texinfo package and (I thought) recover the makeinfo.exe file, but it was not created.  So now I'm wondering where makeinfo exe is coming from.  It's not mentioned in any of my build log files.  I'll keep looking.

John W. Eaton <jwe>
Group administrator
Thu 14 Apr 2016 02:23:50 AM UTC, comment #10: 

It was working when I tested it back when I submitted the change, but yes, now I am seeing the same thing.

Perl should be enabled all the time now.

Unfortunately I will be away from my computer for a few days, so wont be able to push any changes

A quick look shows that when installed it added:

makeinfo.exe

makeinfo.bat

makeinfo


On deleting makeinfo, makeinfo.bat, running makeinfo then runs and prints the usage so maybe  we just need to remove the 2 files that also get installed.

A couple of other packages have done similar things, where it installs multiple types of a program and gets deleted.



John Donoghue <lostbard>
Group Member
Wed 13 Apr 2016 07:43:15 PM UTC, comment #9: 

I'm trying to build 4.0.2.

I thought I would go with the latest mxe-octave since there have been some bug fixes there.  But now it looks like makeinfo is broken?  I'm seeing the following error when print_usage is called.  Is it just me?  Am I doing something wrong?  I built with --enable-devel-tools and I have perl in the bin directory.


>> svd
syntax error at C:\Users\jwe\Desktop\octave-4.0.2\bin\makeinfo line 54, near "my
"
Global symbol "$package" requires explicit package name at C:\Users\jwe\Desktop\o
ctave-4.0.2\bin\makeinfo line 54.
Global symbol "$package" requires explicit package name at C:\Users\jwe\Desktop\o
ctave-4.0.2\bin\makeinfo line 70.
Global symbol "$package" requires explicit package name at C:\Users\jwe\Desktop\o
ctave-4.0.2\bin\makeinfo line 72.
BEGIN not safe after errors--compilation aborted at C:\Users\jwe\Desktop\octave-4
.0.2\bin\makeinfo line 104.
warning: print_usage: Texinfo formatting filter exited abnormally
warning: called from
    print_usage at line 73 column 5
warning: print_usage: raw Texinfo source of help text follows...
error: Invalid call to svd.  Correct usage is:


John W. Eaton <jwe>
Group administrator
Wed 06 Apr 2016 07:27:54 PM UTC, comment #8: 

Closing as fixed

John Donoghue <lostbard>
Group Member
Tue 05 Apr 2016 02:37:49 AM UTC, comment #7: 
John Donoghue <lostbard>
Group Member
Tue 05 Apr 2016 02:08:29 AM UTC, comment #6: 

I'll push the patch I attached to comment #2

John Donoghue <lostbard>
Group Member
Mon 04 Apr 2016 07:29:06 PM UTC, comment #5: 

Yes, go ahead and apply.

Rik <rik5>
Group administrator
Mon 04 Apr 2016 06:47:11 PM UTC, comment #4: 

Octave 4.0.1 is done, apply this now?

Mike Miller <mtmiller>
Group Member
Tue 01 Mar 2016 07:16:15 PM UTC, comment #3: 

Yes to the question in comment #2.  Wait until Octave 4.0.1 is released and then this patch for MXE can be applied.

Rik <rik5>
Group administrator
Sun 13 Dec 2015 03:47:36 PM UTC, comment #2: 

Patch attached that updates texinfo to 6.0.

Should we wait until after the 4.0.1 release before pushing it up?

(file #35728)

John Donoghue <lostbard>
Group Member
Thu 10 Dec 2015 01:19:02 AM UTC, comment #1: 

perl is currently only installed as a binary package from msys if --enable-devel-tools is specified.

Not reason that cant be changed that I know of.

I think I tried adding textinfo 6 at on stage but cant remeber now why I never ended up commiting it, or if there had been some issue.

I'll look through some of my old ptahces and see if I can dig it up, unless someone else gets it working first.




John Donoghue <lostbard>
Group Member
Tue 08 Dec 2015 07:36:46 PM UTC, original submission:  

Recent versions of GNU Texinfo have made some markup improvements, including the appearance of the @samp macro (see this thread: http://lists.gnu.org/archive/html/help-octave/2015-12/msg00119.html).

New versions also change makeinfo from a compiled program to a Perl script. Is Perl already included in the Windows installer? If not that could be a significant blocker to upgrading.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36962:  fixtexinfo.patch added by lostbard (731B - text/x-patch)
file #36926:  makeinfo added by jwe (53KiB - application/octet-stream)
file #35728:  texinfo6.0.patch added by lostbard (37KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by godfrey (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-04-20 rik5 Open/ClosedOpen Closed
    2016-04-19 lostbard Attached File- Added fixtexinfo.patch, #36962
    2016-04-14 jwe Attached File- Added makeinfo, #36926
    2016-04-13 jwe Open/ClosedClosed Open
    2016-04-06 lostbard Open/ClosedOpen Closed
    2016-04-06 lostbard StatusReady For Test Fixed
    2016-04-05 lostbard StatusIn Progress Ready For Test
    2016-04-05 lostbard StatusPatch Submitted In Progress
        Assigned toNone lostbard
    2015-12-13 lostbard Attached File- Added texinfo6.0.patch, #35728
        StatusNeed Info Patch Submitted

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code